Bug 163573 - REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
Summary: REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in th...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-17 16:59 PDT by Tim Horton
Modified: 2016-10-17 17:47 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.55 KB, patch)
2016-10-17 17:02 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-10-17 16:59:56 PDT 
REGRESSION (r169805): WKWebView canGoBack returning YES when nothing is in the back-forward list after restoring session state
Comment 1 Tim Horton 2016-10-17 17:02:33 PDT 
Created attachment 291899 [details]
Patch
Comment 2 Tim Horton 2016-10-17 17:03:01 PDT 
Steps To Reproduce:
1. Create a WKWebView and navigate to a page.
2. Use -[WKWebView _sessionStateWithFilter:] to remove the one item in the WKWebView’s back forward list, and use -[WKWebView _restoreSessionState:andNavigate:] (navigate = NO) to restore the empty back forward list.
3. Observe the value of -[WKWebView canGoBack].

Results:
-[WKWebView canGoBack] returns YES even though there are no items in the back list.

Regression:
This bug was introduced by: https://trac.webkit.org/changeset/169805
Comment 3 WebKit Commit Bot 2016-10-17 17:47:47 PDT 
Comment on attachment 291899 [details]
Patch

Clearing flags on attachment: 291899

Committed r207445: <http://trac.webkit.org/changeset/207445>
Comment 4 WebKit Commit Bot 2016-10-17 17:47:50 PDT 
All reviewed patches have been landed.  Closing bug.