Bug 163555 - CTTE some of the BackForwardList member functions
Summary: CTTE some of the BackForwardList member functions
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
Depends on:
Reported: 2016-10-17 11:30 PDT by Anders Carlsson
Modified: 2016-10-17 12:16 PDT (History)
1 user (show)

See Also:

Patch (5.11 KB, patch)
2016-10-17 11:32 PDT, Anders Carlsson
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-10-17 11:30:34 PDT
CTTE some of the BackForwardList member functions
Comment 1 Anders Carlsson 2016-10-17 11:32:06 PDT
Created attachment 291842 [details]
Comment 2 Darin Adler 2016-10-17 11:36:30 PDT
Comment on attachment 291842 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=291842&action=review

> Source/WebKit/mac/History/WebBackForwardList.mm:208
> -    return core(self)->containsItem(core(item));
> +    if (!item)
> +        return NO;
> +
> +    return core(self)->containsItem(*core(item));

I like to write it like this:

    return item && return core(self)->containsItem(*core(item));
Comment 3 Anders Carlsson 2016-10-17 11:38:05 PDT
Committed r207419: <http://trac.webkit.org/changeset/207419>
Comment 4 Chris Dumez 2016-10-17 12:16:18 PDT
I get a build error on iOS:
/Volumes/Data/cdumez/WebKit/OpenSource/Source/WebKit/mac/History/WebBackForwardList.mm:170:34: error: no matching function for call to 'kit'
        [entriesArray addObject:[kit(historyItems[i].ptr()) dictionaryRepresentationIncludingChildren:NO]];