RESOLVED FIXED Bug 163549
Rename the reject() helper function to something more meaningful. 
https://bugs.webkit.org/show_bug.cgi?id=163549
Summary Rename the reject() helper function to something more meaningful.
Mark Lam
Reported 2016-10-17 10:03:48 PDT
Maybe to failAndThrowTypeErrorIfNeeded()?
Attachments
proposed patch. (50.57 KB, patch)
2016-10-25 17:47 PDT, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mark Lam
Comment 1 2016-10-25 17:15:34 PDT
I spoke with Geoff offline, and he suggested renaming reject() to typeError(). The intuition behind this is that all the clients that uses this function will return typeError(..., shouldThrow, ...). In a sense, they are returning a "type" of TypeError (which happened to be the value false). In addition, it may also throw a JS TypeError is the shouldThrow parameter is true. I think that that name works. I will go ahead and make the change.
Mark Lam
Comment 2 2016-10-25 17:47:59 PDT
Created attachment 292857 [details] proposed patch. Le's try this on the EWS bots first.
Mark Lam
Comment 3 2016-10-25 18:07:37 PDT
Comment on attachment 292857 [details] proposed patch. At least one EWS bot managed to build with this patch. I think it's ready for a review.
Saam Barati
Comment 4 2016-10-25 18:10:25 PDT
Comment on attachment 292857 [details] proposed patch. r=me
Mark Lam
Comment 5 2016-10-25 18:13:58 PDT
Thanks for the review. Landed in r207859: <http://trac.webkit.org/r207859>.
Note You need to log in before you can comment on or make changes to this bug.