Bug 163507 - Eleminate code duplication between ResourceRequest encoding/decoding implementations
Summary: Eleminate code duplication between ResourceRequest encoding/decoding implemen...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Konstantin Tokarev
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-16 12:05 PDT by Konstantin Tokarev
Modified: 2016-10-17 05:02 PDT (History)
7 users (show)

See Also:

Attachments
Patch (10.36 KB, patch)
2016-10-16 12:07 PDT, Konstantin Tokarev 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantin Tokarev 2016-10-16 12:05:13 PDT 
ResourceRequestBase::encodeWithoutPlatformData() and Soup implementation of ArgumentCoder<ResourceRequest>::encodePlatformData() share most of the code, ditto for decoding implementations.
Comment 1 Konstantin Tokarev 2016-10-16 12:07:33 PDT 
Created attachment 291765 [details]
Patch
Comment 2 Carlos Garcia Campos 2016-10-17 04:11:17 PDT 
Comment on attachment 291765 [details]
Patch

Great cleanup! Thanks
Comment 3 WebKit Commit Bot 2016-10-17 05:02:39 PDT 
Comment on attachment 291765 [details]
Patch

Clearing flags on attachment: 291765

Committed r207407: <http://trac.webkit.org/changeset/207407>
Comment 4 WebKit Commit Bot 2016-10-17 05:02:43 PDT 
All reviewed patches have been landed.  Closing bug.