Bug 163500 – [Modern Media Controls] Use modern-media-controls module sources for media controls stylesheet and script injection

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Antoine Quint]

We need to update RenderTheme to use the modern-media-controls module when the runtime flag is on.

[Radar WebKit Bug Importer]

<rdar://problem/28792010>

[Antoine Quint]

Created attachment 291745 [details]
Patch

[Antoine Quint]

Created attachment 291834 [details]
Patch for landing

[Dean Jackson]

Comment on attachment 291834 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=291834&action=review

> Source/WebCore/rendering/RenderThemeMac.mm:241
> +            NSArray* paths = @[@"airplay-button", @"button", @"buttons-container", @"icon-button", @"macos-inline-media-controls", @"media-controls", @"placard", @"scrubber", @"slider", @"start-button", @"time-label", @"volume-slider"];
> +            for (NSString* path in paths)

These should be NSArray *paths and NSString *path. See https://webkit.org/code-style-guidelines/#pointers-and-references (although there is little consistency throughout WebKit here)

> Source/WebCore/rendering/RenderThemeMac.mm:261
> +            NSArray* controlsPaths = @[@"scheduler", @"layout-node", @"layout-item", @"icon-service", @"time-control", @"time-label", @"slider", @"volume-slider", @"scrubber", @"button", @"start-button", @"icon-button", @"play-pause-button", @"skip-back-button", @"mute-button", @"airplay-button", @"pip-button", @"tracks-button", @"fullscreen-button", @"aspect-ratio-button", @"rewind-button", @"forward-button", @"media-controls", @"macos-media-controls", @"macos-inline-media-controls", @"buttons-container", @"placard", @"airplay-placard", @"pip-placard"];
> +            for (NSString* path in controlsPaths)

Same here.

[WebKit Commit Bot]

Comment on attachment 291834 [details]
Patch for landing

Clearing flags on attachment: 291834

Committed r207418: <http://trac.webkit.org/changeset/207418>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.