Bug 163488 - [GTK] Add WebCore API so that UserAgentQuirks test can create its own quirks
Summary: [GTK] Add WebCore API so that UserAgentQuirks test can create its own quirks
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-15 07:43 PDT by Michael Catanzaro
Modified: 2016-10-16 12:53 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-10-15 07:43:24 PDT 
It's not desirable to keep the same list of quirks in both the unit test and the quirks plugin. We should add a WebCore API so that the unit test can add its own quirks, that way it can test that the quirks class works properly without requiring that we update it each time we add new quirks.
Comment 1 Michael Catanzaro 2016-10-16 11:19:48 PDT 
This will also be step one towards reusing the same list of quirks between GTK, WPE, and maybe also EFL ports. We surely want our own port-specific user-agent classes and the quirks will ultimately need to be implemented there, but we can at least move the list of quirks to a central location.
Comment 2 Michael Catanzaro 2016-10-16 12:53:15 PDT 
I wound up changing my mind about this, see bug #163481#c8.

(In reply to comment #1)
> This will also be step one towards reusing the same list of quirks between
> GTK, WPE, and maybe also EFL ports. We surely want our own port-specific
> user-agent classes and the quirks will ultimately need to be implemented
> there, but we can at least move the list of quirks to a central location.

Still want to do this, bug #163508.