Bug 163480 - CounterNode::resetRenderers is so inefficient.
Summary: CounterNode::resetRenderers is so inefficient.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-14 20:16 PDT by zalan
Modified: 2016-10-15 07:27 PDT (History)
5 users (show)

See Also:


Attachments
Patch (15.35 KB, patch)
2016-10-14 20:36 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-10-14 20:16:20 PDT
It calls into RenderCounter::invalidate() which in turn calls back to the CounterNode to remove the renderer.
    while (m_rootRenderer)
        m_rootRenderer->invalidate(); // This makes m_rootRenderer point to the next renderer if any since it disconnects the m_rootRenderer from this.
Comment 1 zalan 2016-10-14 20:36:49 PDT
Created attachment 291702 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-15 07:27:12 PDT
Comment on attachment 291702 [details]
Patch

Clearing flags on attachment: 291702

Committed r207374: <http://trac.webkit.org/changeset/207374>
Comment 3 WebKit Commit Bot 2016-10-15 07:27:16 PDT
All reviewed patches have been landed.  Closing bug.