Bug 163475 – MessageEvent's source property should be a (DOMWindow or MessagePort)? rather than a EventTarget?

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Sam Weinig]

MessageEvent's source property should be a (DOMWindow or MessagePort)? rather than a EventTarget?

[Sam Weinig]

Created attachment 291684 [details]
Patch

[WebKit Commit Bot]

Attachment 291684 [details] did not pass style-queue:


ERROR: Source/WebCore/dom/MessageEvent.h:63:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MessageEvent.h:64:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MessageEvent.h:95:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Tools/TestWebKitAPI/Tests/WTF/Optional.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebCore/ChangeLog:8:  You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible.  [changelog/nonewtests] [5]
Total errors found: 5 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Build Bot]

Comment on attachment 291684 [details]
Patch

Attachment 291684 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2287527

New failing tests:
fast/events/constructors/message-event-constructor.html
fast/dom/message-port-deleted-by-accessor.html

[Build Bot]

Created attachment 291692 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291684 [details]
Patch

Attachment 291684 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2287528

New failing tests:
fast/events/constructors/message-event-constructor.html
fast/dom/message-port-deleted-by-accessor.html

[Build Bot]

Created attachment 291693 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291684 [details]
Patch

Attachment 291684 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2287524

New failing tests:
fast/events/constructors/message-event-constructor.html
fast/dom/message-port-deleted-by-accessor.html

[Build Bot]

Created attachment 291694 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291684 [details]
Patch

Attachment 291684 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2287530

New failing tests:
fast/events/constructors/message-event-constructor.html
fast/dom/message-port-deleted-by-accessor.html

[Build Bot]

Created attachment 291695 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Sam Weinig]

Created attachment 291725 [details]
Patch

[WebKit Commit Bot]

Attachment 291725 [details] did not pass style-queue:


ERROR: Source/WTF/wtf/Variant.h:1947:  Missing space after ,  [whitespace/comma] [3]
ERROR: Source/WebCore/dom/MessageEvent.h:63:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MessageEvent.h:64:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebCore/dom/MessageEvent.h:95:  The parameter name "source" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 4 in 21 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 291725 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291725&action=review

> Source/WebCore/bindings/scripts/test/TestObj.idl:463
> +    (long or Node) unionMember;
> +    (long or Node)? nullableUnionMember = null;

I rather wish we'd stop piling stuff onto this interface and make more targeted tests.

[Sam Weinig]

Committed revision 207381.

[Sam Weinig]

(In reply to comment #13)
> Comment on attachment 291725 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291725&action=review
> 
> > Source/WebCore/bindings/scripts/test/TestObj.idl:463
> > +    (long or Node) unionMember;
> > +    (long or Node)? nullableUnionMember = null;
> 
> I rather wish we'd stop piling stuff onto this interface and make more
> targeted tests.

Any particular reason? The boilerplate of setting up a new test is relatively high and makes the test run quite a bit longer than just adding a new property to an existing one.  I also haven't found it difficult to debug issues with these larger tests.