Bug 16346 - [GTK] Some webview parts must use the focused frame
Summary: [GTK] Some webview parts must use the focused frame
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P3 Normal
Assignee: Nobody
Keywords: Gtk
Depends on:
Reported: 2007-12-07 14:04 PST by Luca Bruno
Modified: 2007-12-08 06:39 PST (History)
0 users

See Also:

patch (15.21 KB, patch)
2007-12-07 14:25 PST, Luca Bruno
no flags Details | Formatted Diff | Diff
keep getViewFromFrame (12.30 KB, patch)
2007-12-08 06:32 PST, Luca Bruno
alp: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Luca Bruno 2007-12-07 14:04:13 PST
some functions of the webview API is using the main frame instead of the focused frame.
Comment 1 Luca Bruno 2007-12-07 14:25:42 PST
Created attachment 17783 [details]

- Use focused frame where needed
- Update old code
- Fix page up and page down for editable contents

This is the rest of the previous patch here applied to all the code: http://bugs.webkit.org/show_bug.cgi?id=16333
Comment 2 Luca Bruno 2007-12-08 06:32:34 PST
Created attachment 17788 [details]
keep getViewFromFrame

This patch keeps getViewFromFrame and add missing webkitprivate.h diff.
Comment 3 Alp Toker 2007-12-08 06:38:18 PST
Comment on attachment 17788 [details]
keep getViewFromFrame

Comment 4 Alp Toker 2007-12-08 06:39:58 PST
Landed in r28564.

It's good that we didn't remove getViewFromFrame() since the future of web_frame_get_web_view() is uncertain.