Bug 163456 - prepare-ChangeLog erroneously said that a python __init__ method was deleted
Summary: prepare-ChangeLog erroneously said that a python __init__ method was deleted
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-14 11:31 PDT by Simon Fraser (smfr)
Modified: 2016-10-16 20:06 PDT (History)
4 users (show)

See Also:

Attachments
Patch and unit tests (10.76 KB, patch)
2016-10-14 16:02 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-14 11:31:27 PDT 
The patch in https://bugs.webkit.org/attachment.cgi?id=291568 shows:

+        (Reviewer.__init__): Deleted.

even though that patch did not delete it.
Comment 1 Daniel Bates 2016-10-14 16:02:42 PDT 
Created attachment 291676 [details]
Patch and unit tests
Comment 2 Daniel Bates 2016-10-15 15:06:48 PDT 
Comment on attachment 291676 [details]
Patch and unit tests

Clearing flags on attachment: 291676

Committed r207382: <http://trac.webkit.org/changeset/207382>
Comment 3 Daniel Bates 2016-10-15 15:06:54 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Michael Catanzaro 2016-10-16 17:05:58 PDT 
It introduced a Perl warning, can you fix it please?

"my" variable @afterChangeFunctionRanges masks earlier declaration in same scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line 359.
Comment 5 Daniel Bates 2016-10-16 20:06:16 PDT 
(In reply to comment #4)
> It introduced a Perl warning, can you fix it please?
> 
> "my" variable @afterChangeFunctionRanges masks earlier declaration in same
> scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line
> 359.

Fixed in <http://trac.webkit.org/changeset/207399>.