RESOLVED FIXED 163456
prepare-ChangeLog erroneously said that a python __init__ method was deleted 
https://bugs.webkit.org/show_bug.cgi?id=163456
Summary prepare-ChangeLog erroneously said that a python __init__ method was deleted
Simon Fraser (smfr)
Reported 2016-10-14 11:31:27 PDT
The patch in https://bugs.webkit.org/attachment.cgi?id=291568 shows: + (Reviewer.__init__): Deleted. even though that patch did not delete it.
Attachments
Patch and unit tests (10.76 KB, patch)
2016-10-14 16:02 PDT, Daniel Bates 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Daniel Bates
Comment 1 2016-10-14 16:02:42 PDT
Created attachment 291676 [details] Patch and unit tests
Daniel Bates
Comment 2 2016-10-15 15:06:48 PDT
Comment on attachment 291676 [details] Patch and unit tests Clearing flags on attachment: 291676 Committed r207382: <http://trac.webkit.org/changeset/207382>
Daniel Bates
Comment 3 2016-10-15 15:06:54 PDT
All reviewed patches have been landed. Closing bug.
Michael Catanzaro
Comment 4 2016-10-16 17:05:58 PDT
It introduced a Perl warning, can you fix it please? "my" variable @afterChangeFunctionRanges masks earlier declaration in same scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line 359.
Daniel Bates
Comment 5 2016-10-16 20:06:16 PDT
(In reply to comment #4) > It introduced a Perl warning, can you fix it please? > > "my" variable @afterChangeFunctionRanges masks earlier declaration in same > scope at /home/mcatanzaro/src/WebKit/Tools/Scripts/prepare-ChangeLog line > 359. Fixed in <http://trac.webkit.org/changeset/207399>.
Note You need to log in before you can comment on or make changes to this bug.