Bug 163451 - [CMake] Private/unsupported build options should be marked as advanced
Summary: [CMake] Private/unsupported build options should be marked as advanced
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-14 09:56 PDT by Michael Catanzaro
Modified: 2016-10-14 11:31 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.48 KB, patch)
2016-10-14 10:30 PDT, Michael Catanzaro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-10-14 09:56:58 PDT
Private/unsupported build options should be marked as advanced so that they are hidden to users listing CMake options (e.g. with 'cmake -L').
Comment 1 Michael Catanzaro 2016-10-14 09:57:54 PDT
Er wait, we already have code for this (WebKitFeatures.cmake):

        option(${_name} "${_WEBKIT_AVAILABLE_OPTIONS_DESCRIPTION_${_name}}" ${_WEBKIT_AVAILABLE_OPTIONS_INITIAL_VALUE_${_name}})
        if (NOT _WEBKIT_AVAILABLE_OPTIONS_IS_PUBLIC_${_name})
            mark_as_advanced(FORCE ${_name})
        endif ()
Comment 2 Michael Catanzaro 2016-10-14 10:30:02 PDT
Created attachment 291645 [details]
Patch
Comment 3 WebKit Commit Bot 2016-10-14 11:31:54 PDT
Comment on attachment 291645 [details]
Patch

Clearing flags on attachment: 291645

Committed r207351: <http://trac.webkit.org/changeset/207351>
Comment 4 WebKit Commit Bot 2016-10-14 11:31:58 PDT
All reviewed patches have been landed.  Closing bug.