RESOLVED FIXED Bug 163441
resolve-ChangeLogs: Specify --no-page to git diff 
https://bugs.webkit.org/show_bug.cgi?id=163441
Summary resolve-ChangeLogs: Specify --no-page to git diff
Fujii Hironori
Reported 2016-10-14 02:52:30 PDT
resolve-ChangeLogs shows the result after resolving by invoking 'git diff'. It runs a pager for every ChangeLog if it is under TTY.
Attachments
Patch (1.39 KB, patch)
2016-10-14 02:57 PDT, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2016-10-14 02:57:13 PDT
Created attachment 291605 [details] Patch
Darin Adler
Comment 2 2016-10-17 10:45:47 PDT
Comment on attachment 291605 [details] Patch Sorry, could you explain why this is an improvement? If I am running this script from the TTY, why wouldn’t I want the diff paged?
Darin Adler
Comment 3 2016-10-17 10:46:24 PDT
I guess maybe because it’s multiple diffs and we want to look at them all in a row?
Darin Adler
Comment 4 2016-10-17 10:47:54 PDT
Comment on attachment 291605 [details] Patch OK, I thought it through and I guess this is fine.
WebKit Commit Bot
Comment 5 2016-10-17 11:01:57 PDT
Comment on attachment 291605 [details] Patch Clearing flags on attachment: 291605 Committed r207416: <http://trac.webkit.org/changeset/207416>
WebKit Commit Bot
Comment 6 2016-10-17 11:02:02 PDT
All reviewed patches have been landed. Closing bug.
Fujii Hironori
Comment 7 2016-10-17 19:38:27 PDT
Thank you for reviewing my patch. After this change, it outputs like following: > $ ./Tools/Scripts/resolve-ChangeLogs > M ChangeLog > M Source/WebCore/ChangeLog > M Tools/ChangeLog But, without this change, Pager was invoked three times because of three ChangeLog files resolved.
Note You need to log in before you can comment on or make changes to this bug.