bug 146306 introduces two new test files that are worth executing in Mac bots as well
Created attachment 291602 [details] Patch for landing
In the past, I was usually doing those changes by editing directly the Xcode files. For WebCore at least, this is usually ok by doing copy-and-paste existing lines, changing the IDs a bit. Each file usually needs two IDs which are close but different, needs to be a bit cautious about that. This patch could serve as a template somehow.
Comment on attachment 291602 [details] Patch for landing Clearing flags on attachment: 291602 Committed r207335: <http://trac.webkit.org/changeset/207335>
All reviewed patches have been landed. Closing bug.
WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/650
Re-opened since this is blocked by bug 163445
(In reply to comment #5) > WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > builds/650 Thanks ryan!
Weird, it passes in GTK+ bots: **PASS** WebKit2.ProvisionalURLAfterWillSendRequestCallback It's cross-platform code, there must be something else.
We only wait for didCommitLoadForFrame to be called in that test.