Bug 163440 - Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds
Summary: Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWil...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
Depends on: 163445
  Show dependency treegraph
Reported: 2016-10-14 02:27 PDT by youenn fablet
Modified: 2016-10-14 08:48 PDT (History)
5 users (show)

See Also:

Patch for landing (6.10 KB, patch)
2016-10-14 02:29 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-14 02:27:11 PDT
bug 146306 introduces two new test files that are worth executing in Mac bots as well
Comment 1 youenn fablet 2016-10-14 02:29:00 PDT
Created attachment 291602 [details]
Patch for landing
Comment 2 youenn fablet 2016-10-14 02:32:43 PDT
In the past, I was usually doing those changes by editing directly the Xcode files.
For WebCore at least, this is usually ok by doing copy-and-paste existing lines, changing the IDs a bit.

Each file usually needs two IDs which are close but different, needs to be a bit cautious about that. This patch could serve as a template somehow.
Comment 3 WebKit Commit Bot 2016-10-14 03:25:56 PDT
Comment on attachment 291602 [details]
Patch for landing

Clearing flags on attachment: 291602

Committed r207335: <http://trac.webkit.org/changeset/207335>
Comment 4 WebKit Commit Bot 2016-10-14 03:26:00 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Ryan Haddad 2016-10-14 08:29:29 PDT
WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out:
Comment 6 WebKit Commit Bot 2016-10-14 08:40:41 PDT
Re-opened since this is blocked by bug 163445
Comment 7 youenn fablet 2016-10-14 08:41:07 PDT
(In reply to comment #5)
> WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out:
> https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/
> builds/650

Thanks ryan!
Comment 8 Carlos Garcia Campos 2016-10-14 08:44:16 PDT
Weird, it passes in GTK+ bots:

**PASS** WebKit2.ProvisionalURLAfterWillSendRequestCallback

It's cross-platform code, there must be something else.
Comment 9 Carlos Garcia Campos 2016-10-14 08:48:56 PDT
We only wait for didCommitLoadForFrame to be called in that test.