REOPENED 163440
Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWillSendRequestCallback_Bundle.cpp to Mac builds 
https://bugs.webkit.org/show_bug.cgi?id=163440
Summary Add ProvisionalURLAfterWillSendRequestCallback.cpp and ProvisionalURLAfterWil...
youenn fablet
Reported 2016-10-14 02:27:11 PDT
bug 146306 introduces two new test files that are worth executing in Mac bots as well
Attachments
Patch for landing (6.10 KB, patch)
2016-10-14 02:29 PDT, youenn fablet 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
youenn fablet
Comment 1 2016-10-14 02:29:00 PDT
Created attachment 291602 [details] Patch for landing
youenn fablet
Comment 2 2016-10-14 02:32:43 PDT
In the past, I was usually doing those changes by editing directly the Xcode files. For WebCore at least, this is usually ok by doing copy-and-paste existing lines, changing the IDs a bit. Each file usually needs two IDs which are close but different, needs to be a bit cautious about that. This patch could serve as a template somehow.
WebKit Commit Bot
Comment 3 2016-10-14 03:25:56 PDT
Comment on attachment 291602 [details] Patch for landing Clearing flags on attachment: 291602 Committed r207335: <http://trac.webkit.org/changeset/207335>
WebKit Commit Bot
Comment 4 2016-10-14 03:26:00 PDT
All reviewed patches have been landed. Closing bug.
Ryan Haddad
Comment 5 2016-10-14 08:29:29 PDT
WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/builds/650
WebKit Commit Bot
Comment 6 2016-10-14 08:40:41 PDT
Re-opened since this is blocked by bug 163445
youenn fablet
Comment 7 2016-10-14 08:41:07 PDT
(In reply to comment #5) > WebKit2.ProvisionalURLAfterWillSendRequestCallback is timing out: > https://build.webkit.org/builders/Apple%20Sierra%20Release%20WK1%20(Tests)/ > builds/650 Thanks ryan!
Carlos Garcia Campos
Comment 8 2016-10-14 08:44:16 PDT
Weird, it passes in GTK+ bots: **PASS** WebKit2.ProvisionalURLAfterWillSendRequestCallback It's cross-platform code, there must be something else.
Carlos Garcia Campos
Comment 9 2016-10-14 08:48:56 PDT
We only wait for didCommitLoadForFrame to be called in that test.
Note You need to log in before you can comment on or make changes to this bug.