Bug 163435 – preprocessor.pm: cl.exe outputs processing filenames if Windows Perl is used

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Fujii Hironori]

Use open3 instead of open2.

A following bug changed open3 to open2 in Windows Perl.

  Bug 91548 – Use cl to preprocess IDL for Chromium Windows generate_supplemental_dependency

A following bug introduced open3 for cl.exe.

  Bug 143219 – Allow building on Windows without Cygwin


IPC::Open3 - perldoc.perl.org
http://perldoc.perl.org/IPC/Open3.html

[Fujii Hironori]

Created attachment 291601 [details]
Patch

[Fujii Hironori]

WinCairo port uses Windows Perl.
For example, this problem can be observed in a following build log:

https://build.webkit.org/builders/WinCairo%2064-Bit%20Release/builds/61992/steps/compile-webkit/logs/stdio

> [7/408] Generating ../../DerivedSources/WebCore/JSCSSStyleSheet.cpp, ../../DerivedSources/WebCore/JSCSSStyleSheet.h
> [8/408] Generating ../../DerivedSources/WebCore/JSCSSSupportsRule.cpp, ../../DerivedSources/WebCore/JSCSSSupportsRule.h
> [9/408] Generating ../../DerivedSources/WebCore/JSCSSCharsetRule.cpp, ../../DerivedSources/WebCore/JSCSSCharsetRule.h
> [10/408] Generating ../../DerivedSources/WebCore/JSCSSValue.cpp, ../../DerivedSources/WebCore/JSCSSValue.h
> [11/408] Generating ../../DerivedSources/WebCore/JSCSSPrimitiveValue.cpp, ../../DerivedSources/WebCore/JSCSSPrimitiveValue.h
> [12/408] Generating ../../DerivedSources/WebCore/JSCSSRule.cpp, ../../DerivedSources/WebCore/JSCSSRule.h
> [13/408] Generating ../../DerivedSources/WebCore/JSCSSStyleDeclaration.cpp, ../../DerivedSources/WebCore/JSCSSStyleDeclaration.h
> [14/408] Generating ../../DerivedSources/WebCore/JSFontFace.cpp, ../../DerivedSources/WebCore/JSFontFace.h
> [15/408] Generating ../../DerivedSources/WebCore/JSCSSMediaRule.cpp, ../../DerivedSources/WebCore/JSCSSMediaRule.h
> [16/408] Generating ../../DerivedSources/WebCore/JSMediaList.cpp, ../../DerivedSources/WebCore/JSMediaList.h
> [17/408] Generating ../../DerivedSources/WebCore/JSFontFaceSet.cpp, ../../DerivedSources/WebCore/JSFontFaceSet.h
> [18/408] Generating ../../DerivedSources/WebCore/JSWebKitCSSMatrix.cpp, ../../DerivedSources/WebCore/JSWebKitCSSMatrix.h
> CSSValue.idl
> 
> CSSMediaRule.idl
> 
> CSSRule.idl
> 
> WebKitCSSMatrix.idl
> 
> CSSSupportsRule.idl
> 
> CSSRule.idl
> 
> CSSRule.idl
> 
> MediaList.idl
> 
> FontFace.idl
> 
> FontFace.idl
> 
> CSSStyleDeclaration.idl
> 
> CSSCharsetRule.idl
> 
> CSSRule.idl
> 
> CSSStyleSheet.idl
> 
> StyleSheet.idl
> 
> CSSPrimitiveValue.idl
> 
> CSSValue.idl
> 
> FontFaceSet.idl
> 
> EventTarget.idl
> 
> FontFace.idl

[WebKit Commit Bot]

Comment on attachment 291601 [details]
Patch

Clearing flags on attachment: 291601

Committed r207412: <http://trac.webkit.org/changeset/207412>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.