Bug 163429 – [Web IDL] Update [CachedAttribute]'s behavior now that we support [SameObject]

• Status: ASSIGNED
• Component: Bindings

[Chris Dumez]

[SameObject] and [CachedAttribute] currently mean the same thing, so to clean things up:
- Rename [CachedAttribute] to [SameObject] in all IDLs where we always return the same object.
- Update [CachedAttribute] to ask the implementation since if the value has changed since the last access before actually using the cached value. This allows for caching attributes but adds flexibility by supporting invalidation. This is used now used by History.state instead of using custom bindings code to achieve this. In a follow-up patch, this will also be used for MessageEvent.data to fix a bug. I am also considering making [CachedAttribute] being the implicit default for FrozenArray attributes to match the specification more closely.

[Chris Dumez]

Created attachment 291563 [details]
Patch

[Chris Dumez]

Created attachment 291565 [details]
Patch

[Chris Dumez]

Created attachment 291569 [details]
Patch

[Build Bot]

Comment on attachment 291569 [details]
Patch

Attachment 291569 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2282189

New failing tests:
fast/loader/stateobjects/state-attribute-history-getter.html

[Build Bot]

Created attachment 291575 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Build Bot]

Comment on attachment 291569 [details]
Patch

Attachment 291569 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2282227

New failing tests:
fast/loader/stateobjects/state-attribute-history-getter.html

[Build Bot]

Created attachment 291576 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291569 [details]
Patch

Attachment 291569 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2282312

New failing tests:
fast/loader/stateobjects/state-attribute-history-getter.html

[Build Bot]

Created attachment 291577 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291569 [details]
Patch

Attachment 291569 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2282332

New failing tests:
fast/loader/stateobjects/state-attribute-history-getter.html

[Build Bot]

Created attachment 291579 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 291647 [details]
Patch

[Build Bot]

Comment on attachment 291647 [details]
Patch

Attachment 291647 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2285701

New failing tests:
fast/loader/stateobjects/replacestate-then-pushstate.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/state-attribute-popstate-event.html
fast/loader/stateobjects/document-destroyed-navigate-back.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html

[Build Bot]

Created attachment 291655 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291647 [details]
Patch

Attachment 291647 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2285746

New failing tests:
fast/loader/stateobjects/replacestate-then-pushstate.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/state-attribute-popstate-event.html
fast/loader/stateobjects/document-destroyed-navigate-back.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html

[Build Bot]

Created attachment 291656 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291647 [details]
Patch

Attachment 291647 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2285785

New failing tests:
fast/loader/stateobjects/replacestate-then-pushstate.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html
fast/loader/stateobjects/state-attribute-popstate-event.html
fast/loader/stateobjects/document-destroyed-navigate-back.html
fast/loader/stateobjects/pushstate-with-fragment-urls-and-hashchange.html

[Build Bot]

Created attachment 291658 [details]
Archive of layout-test-results from ews107 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews107  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291647 [details]
Patch

Attachment 291647 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2285789

New failing tests:
fast/loader/stateobjects/state-attribute-popstate-event.html
fast/loader/stateobjects/replacestate-then-pushstate.html
fast/loader/stateobjects/document-destroyed-navigate-back.html
fast/loader/stateobjects/pushstate-object-types.html
fast/loader/stateobjects/document-destroyed-navigate-back-with-fragment-scroll.html

[Build Bot]

Created attachment 291659 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6