Bug 163428 - Web Inspector: Improve debugger highlight when inside of getter/setter calls
Summary: Web Inspector: Improve debugger highlight when inside of getter/setter calls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-13 20:43 PDT by Joseph Pecoraro
Modified: 2016-10-14 16:06 PDT (History)
7 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (6.07 KB, patch)
2016-10-13 20:46 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-13 20:43:14 PDT
Summary:
Improve debugger highlight when inside of getter/setter calls.

When paused inside of a getter/setter the user may select the parent call frame to see where the getter/setter was invoked. In these cases we should highlight the best part of the parent member expression that we can. 

For example:

    - * is the location JavaScriptCore tells us we are (the divot)
    - |...| is the range we want to highlight

Triggering getter via dot access:

    foo*.x.y.z => inside x looking at parent call frame => |foo.x|.y.z
    foo.x*.y.z => inside y looking at parent call frame => |foo.x.y|.z

Triggering getter via bracket access:

    foo*["x"]["y"]["z"] => inside x looking at parent call frame => |foo["x"]|["y"]["z"]
    foo["x"]*["y"]["z"] => inside y looking at parent call frame => |foo["x"]["y"]|["z"]

We already highlight the most useful expression when inside of a function call:

    func*(foo.x) => inside func => |func(foo.x)|
    foo.func*(x) => inside func => |foo.func(x)|
Comment 1 Radar WebKit Bug Importer 2016-10-13 20:43:35 PDT
<rdar://problem/28769061>
Comment 2 Joseph Pecoraro 2016-10-13 20:46:17 PDT
Created attachment 291562 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-10-14 16:06:45 PDT
Comment on attachment 291562 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 291562

Committed r207358: <http://trac.webkit.org/changeset/207358>
Comment 4 WebKit Commit Bot 2016-10-14 16:06:51 PDT
All reviewed patches have been landed.  Closing bug.