Bug 163428 – Web Inspector: Improve debugger highlight when inside of getter/setter calls

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

Summary:
Improve debugger highlight when inside of getter/setter calls.

When paused inside of a getter/setter the user may select the parent call frame to see where the getter/setter was invoked. In these cases we should highlight the best part of the parent member expression that we can. 

For example:

    - * is the location JavaScriptCore tells us we are (the divot)
    - |...| is the range we want to highlight

Triggering getter via dot access:

    foo*.x.y.z => inside x looking at parent call frame => |foo.x|.y.z
    foo.x*.y.z => inside y looking at parent call frame => |foo.x.y|.z

Triggering getter via bracket access:

    foo*["x"]["y"]["z"] => inside x looking at parent call frame => |foo["x"]|["y"]["z"]
    foo["x"]*["y"]["z"] => inside y looking at parent call frame => |foo["x"]["y"]|["z"]

We already highlight the most useful expression when inside of a function call:

    func*(foo.x) => inside func => |func(foo.x)|
    foo.func*(x) => inside func => |foo.func(x)|

[Radar WebKit Bug Importer]

<rdar://problem/28769061>

[Joseph Pecoraro]

Created attachment 291562 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 291562 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 291562

Committed r207358: <http://trac.webkit.org/changeset/207358>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.