Bug 163418 - Move BackForwardList from WebCore to WebKitLegacy
Summary: Move BackForwardList from WebCore to WebKitLegacy
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-13 16:30 PDT by Anders Carlsson
Modified: 2016-10-14 10:17 PDT (History)
1 user (show)

See Also:

Attachments
Patch (47.00 KB, patch)
2016-10-13 16:34 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (46.99 KB, patch)
2016-10-13 16:43 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (46.96 KB, patch)
2016-10-13 16:50 PDT, Anders Carlsson 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2016-10-13 16:30:35 PDT 
Move BackForwardList from WebCore to WebKitLegacy
Comment 1 Anders Carlsson 2016-10-13 16:34:29 PDT 
Created attachment 291535 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-13 16:37:11 PDT 
Attachment 291535 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:97:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:100:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:145:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:209:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Anders Carlsson 2016-10-13 16:43:21 PDT 
Created attachment 291537 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-13 16:44:50 PDT 
Attachment 291537 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:97:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:100:  Omit int when using unsigned  [runtime/unsigned] [1]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:145:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:209:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Anders Carlsson 2016-10-13 16:50:55 PDT 
Created attachment 291538 [details]
Patch
Comment 6 WebKit Commit Bot 2016-10-13 16:53:36 PDT 
Attachment 291538 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/History/BackForwardList.mm:27:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:96:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:144:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/BackForwardList.mm:208:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:32:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardList.mm:335:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
ERROR: Source/WebKit/mac/WebView/WebView.mm:34:  Alphabetical sorting problem.  [build/include_order] [4]
ERROR: Source/WebKit/mac/History/WebBackForwardListInternal.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 8 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Anders Carlsson 2016-10-14 10:17:19 PDT 
Committed r207345: <http://trac.webkit.org/changeset/207345>