Bug 163408 – Web Inspector: Call RuntimeAgent.disableTypeProfiler when Type Profiler is turned off

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Disabling Type Profiler by clicking the [T] button should signal the backend to stop collecting the data by calling RuntimeAgent.disableTypeProfiler method.

RuntimeAgent.disableTypeProfiler is currently unused.

[Radar WebKit Bug Importer]

<rdar://problem/28764269>

[Nikita Vasilyev]

There's a comment in _setTypeTokenAnnotatorEnabledState method:

// Because we disable type profiling when exiting the inspector, there is no need to call
// RuntimeAgent.disableTypeProfiler() here.  If we were to call it here, JavaScriptCore would
// compile out all the necessary type profiling information, so if a user were to quickly press then
// unpress the type profiling button, we wouldn't be able to re-show type information which would
// provide a confusing user experience.

Sometimes I disable Type Profiler to read code with less distractions and then turn it back on.
Unlike Code Coverage, enabling Type Profiler adds tokens that take up space.

I think it makes a lot of sense to call RuntimeAgent.disableControlFlowProfiler() when turning off Code Coverage
by clicking [C] icon. Disabling Type Profiler, however, has drawbacks.

Any opinions?

[Nikita Vasilyev]

Created attachment 294517 [details]
Patch

Here's a patch that makes Type Profiler consistent with Code Coverage.

[WebKit Commit Bot]

Comment on attachment 294517 [details]
Patch

Clearing flags on attachment: 294517

Committed r208604: <http://trac.webkit.org/changeset/208604>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.