Bug 163400 - Web Inspector: Cleanup parts of DebuggerManager
Summary: Web Inspector: Cleanup parts of DebuggerManager
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: DoNotImportToRadar
Depends on:
Blocks:
 
Reported: 2016-10-13 12:53 PDT by Joseph Pecoraro
Modified: 2016-10-15 00:25 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (26.33 KB, patch)
2016-10-13 12:58 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix (26.32 KB, patch)
2016-10-13 13:01 PDT, Joseph Pecoraro
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-10-13 12:53:52 PDT
Summary:
Cleanup parts of DebuggerManager

  - public methods are all over the place, can be much better grouped
  - modernize some uses of let/for loops
  - declare all members in constructor (for clarity)
  - some public methods have unused features (addBreakpoint)
Comment 1 Joseph Pecoraro 2016-10-13 12:58:34 PDT
Created attachment 291506 [details]
[PATCH] Proposed Fix
Comment 2 Joseph Pecoraro 2016-10-13 13:01:50 PDT
Created attachment 291507 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2016-10-13 13:41:57 PDT
This doesn't apply because of other patches still out for review.
Comment 4 Joseph Pecoraro 2016-10-15 00:25:12 PDT
<https://trac.webkit.org/changeset/207371>