WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 163400
Web Inspector: Cleanup parts of DebuggerManager
https://bugs.webkit.org/show_bug.cgi?id=163400
Summary
Web Inspector: Cleanup parts of DebuggerManager
Joseph Pecoraro
Reported
2016-10-13 12:53:52 PDT
Summary: Cleanup parts of DebuggerManager - public methods are all over the place, can be much better grouped - modernize some uses of let/for loops - declare all members in constructor (for clarity) - some public methods have unused features (addBreakpoint)
Attachments
[PATCH] Proposed Fix
(26.33 KB, patch)
2016-10-13 12:58 PDT
,
Joseph Pecoraro
no flags
Details
Formatted Diff
Diff
[PATCH] Proposed Fix
(26.32 KB, patch)
2016-10-13 13:01 PDT
,
Joseph Pecoraro
timothy
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Joseph Pecoraro
Comment 1
2016-10-13 12:58:34 PDT
Created
attachment 291506
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 2
2016-10-13 13:01:50 PDT
Created
attachment 291507
[details]
[PATCH] Proposed Fix
Joseph Pecoraro
Comment 3
2016-10-13 13:41:57 PDT
This doesn't apply because of other patches still out for review.
Joseph Pecoraro
Comment 4
2016-10-15 00:25:12 PDT
<
https://trac.webkit.org/changeset/207371
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug