Bug 163374 – [macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[macOS] [iOS] Disable variation fonts on macOS El Capitan and iOS 9

[Myles C. Maxfield]

Created attachment 291441 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 291441 [details]
Patch

Do we actually want the CSS properties to disappear on earlier OSes, or do we just want them to be no-ops?

[Myles C. Maxfield]

(In reply to comment #2)
> Comment on attachment 291441 [details]
> Patch
> 
> Do we actually want the CSS properties to disappear on earlier OSes, or do
> we just want them to be no-ops?

We don't want @supports to lie.

[Myles C. Maxfield]

(In reply to comment #3)
> (In reply to comment #2)
> > Comment on attachment 291441 [details]
> > Patch
> > 
> > Do we actually want the CSS properties to disappear on earlier OSes, or do
> > we just want them to be no-ops?
> 
> We don't want @supports to lie.

For that same reason, @supports also shouldn't lie when the runtime switch is disabled, right? Now that we have a compile time switch and the runtime switch is on by default, do we even need the runtime switch anymore?

[Build Bot]

Comment on attachment 291441 [details]
Patch

Attachment 291441 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2274270

New failing tests:
fast/text/variations/advances.html
animations/font-variations/font-variation-settings-unlike.html
animations/font-variations/font-variation-settings.html
fast/text/variations/getComputedStyle.html

[Build Bot]

Created attachment 291447 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291441 [details]
Patch

Attachment 291441 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2274279

New failing tests:
fast/text/variations/advances.html
animations/font-variations/font-variation-settings-unlike.html
animations/font-variations/font-variation-settings.html
fast/text/variations/getComputedStyle.html

[Build Bot]

Created attachment 291449 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291441 [details]
Patch

Attachment 291441 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2274293

New failing tests:
fast/text/variations/advances.html
animations/font-variations/font-variation-settings-unlike.html
animations/font-variations/font-variation-settings.html
fast/text/variations/getComputedStyle.html

[Build Bot]

Created attachment 291450 [details]
Archive of layout-test-results from ews116 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews116  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291441 [details]
Patch

Attachment 291441 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2274299

New failing tests:
media/controls/ipad/close-page-with-picture-in-picture-video-assertion-failure.html

[Build Bot]

Created attachment 291451 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 291453 [details]
Patch

[Alex Christensen]

Comment on attachment 291453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291453&action=review

> Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:211
> +ENABLE_VARIATION_FONTS_macosx_101300 = ENABLE_VARIATION_FONTS;

It would be nice if this could default to enabled except for old OSes so we won't accidentally forget to change this when we start to build for 10.14

[Alex Christensen]

View in context: https://bugs.webkit.org/attachment.cgi?id=291453&action=review

> Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:211
> +ENABLE_VARIATION_FONTS_macosx_101300 = ENABLE_VARIATION_FONTS;

It would be nice if this could default to enabled except for old OSes so we won't accidentally forget to change this when we start to build for 10.14

[Darin Adler]

Comment on attachment 291453 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291453&action=review

>> Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:211
>> +ENABLE_VARIATION_FONTS_macosx_101300 = ENABLE_VARIATION_FONTS;
> 
> It would be nice if this could default to enabled except for old OSes so we won't accidentally forget to change this when we start to build for 10.14

Seems critical, in fact, that old versions are listed, not new versions. Is there some reason we can’t easily do that?

> LayoutTests/platform/ios-simulator/TestExpectations:2710
> +# Font variations are not implemented on iOS 9.
> +fast/text/variations [ Pass Failure ImageOnlyFailure ]
> +animations/font-variations [ Pass Failure ImageOnlyFailure ]

The expectations in this file aren’t specific to iOS 9, so that comment is confusing.

[Darin Adler]

Comment on attachment 291453 [details]
Patch

Myles, can you find a way to do this that enumerates the old versions of macOS instead of the new versions?

[Myles C. Maxfield]

(In reply to comment #16)
> Comment on attachment 291453 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291453&action=review
> 
> >> Source/WebKit/mac/Configurations/FeatureDefines.xcconfig:211
> >> +ENABLE_VARIATION_FONTS_macosx_101300 = ENABLE_VARIATION_FONTS;
> > 
> > It would be nice if this could default to enabled except for old OSes so we won't accidentally forget to change this when we start to build for 10.14
> 
> Seems critical, in fact, that old versions are listed, not new versions. Is
> there some reason we can’t easily do that?
> 
> > LayoutTests/platform/ios-simulator/TestExpectations:2710
> > +# Font variations are not implemented on iOS 9.
> > +fast/text/variations [ Pass Failure ImageOnlyFailure ]
> > +animations/font-variations [ Pass Failure ImageOnlyFailure ]
> 
> The expectations in this file aren’t specific to iOS 9, so that comment is
> confusing.

I don't believe there is currently a mechanism for discriminating between iOS 9 and iOS 10 in TestExpectations.

[Myles C. Maxfield]

Created attachment 291897 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 291898 [details]
Patch for committing

[Build Bot]

Comment on attachment 291898 [details]
Patch for committing

Attachment 291898 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2307909

New failing tests:
animations/font-variations/font-variation-settings-unlike.html
animations/font-variations/font-variation-settings.html
animations/font-variations/font-variation-settings-order.html
fast/text/variations/getComputedStyle.html

[Build Bot]

Created attachment 291909 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 291985 [details]
Patch for committing

[Myles C. Maxfield]

Created attachment 291987 [details]
Patch for committing

[Build Bot]

Comment on attachment 291987 [details]
Patch for committing

Attachment 291987 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2318192

New failing tests:
animations/font-variations/font-variation-settings.html
fast/text/variations/getComputedStyle.html

[Build Bot]

Created attachment 292001 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6

[Myles C. Maxfield]

Created attachment 292005 [details]
Patch for committing

[WebKit Commit Bot]

Comment on attachment 292005 [details]
Patch for committing

Clearing flags on attachment: 292005

Committed r207557: <http://trac.webkit.org/changeset/207557>

[Ryan Haddad]

Reverted r207557 for reason:

This change caused animations/font-variations tests to time out on pre-Sierra Macs.

Committed r207568: <http://trac.webkit.org/changeset/207568>

[Myles C. Maxfield]

Committed r207642: <http://trac.webkit.org/changeset/207642>