Bug 163369 - Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event]
Summary: Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using l...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 16:54 PDT by Chris Dumez
Modified: 2016-10-12 22:21 PDT (History)
5 users (show)

See Also:


Attachments
Patch (13.89 KB, patch)
2016-10-12 16:56 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (18.15 KB, patch)
2016-10-12 19:08 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews126 for ios-simulator-wk2 (8.87 MB, application/zip)
2016-10-12 20:26 PDT, Build Bot
no flags Details
Patch (19.60 KB, patch)
2016-10-12 20:38 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-12 16:54:24 PDT
Update WebKitMediaKeyMessageEvent / WebKitMediaKeyNeededEvent to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Comment 1 Chris Dumez 2016-10-12 16:56:30 PDT
Created attachment 291422 [details]
Patch
Comment 2 Chris Dumez 2016-10-12 19:08:56 PDT
Created attachment 291439 [details]
Patch
Comment 3 Chris Dumez 2016-10-12 19:48:20 PDT
Comment on attachment 291439 [details]
Patch

Looks like my new test fails in debug. I'll investigate.
Comment 4 Build Bot 2016-10-12 20:25:56 PDT
Comment on attachment 291439 [details]
Patch

Attachment 291439 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2274231

New failing tests:
fast/events/webkit-media-key-events-constructor.html
Comment 5 Build Bot 2016-10-12 20:26:00 PDT
Created attachment 291446 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 6 Chris Dumez 2016-10-12 20:38:41 PDT
Created attachment 291448 [details]
Patch
Comment 7 WebKit Commit Bot 2016-10-12 22:21:39 PDT
Comment on attachment 291448 [details]
Patch

Clearing flags on attachment: 291448

Committed r207277: <http://trac.webkit.org/changeset/207277>
Comment 8 WebKit Commit Bot 2016-10-12 22:21:44 PDT
All reviewed patches have been landed.  Closing bug.