Bug 163358 - Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements
Summary: Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 163296
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-12 14:18 PDT by Chris Dumez
Modified: 2016-10-12 21:16 PDT (History)
7 users (show)

See Also:


Attachments
Patch (4.61 KB, patch)
2016-10-12 15:48 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-12 14:18:37 PDT
Update HTMLSelectElement::recalcListItems() to ignore nested optgroup elements. As per the specification, we only want optgroup elements that are direct children of the select element.
Comment 1 Chris Dumez 2016-10-12 15:35:47 PDT
test case:
https://jsfiddle.net/varkv40b/10/
Comment 2 Chris Dumez 2016-10-12 15:40:44 PDT
(In reply to comment #1)
> test case:
> https://jsfiddle.net/varkv40b/10/

Better: https://jsfiddle.net/varkv40b/16/
Comment 3 Chris Dumez 2016-10-12 15:48:33 PDT
Created attachment 291410 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-12 21:16:26 PDT
Comment on attachment 291410 [details]
Patch

Clearing flags on attachment: 291410

Committed r207276: <http://trac.webkit.org/changeset/207276>
Comment 5 WebKit Commit Bot 2016-10-12 21:16:31 PDT
All reviewed patches have been landed.  Closing bug.