WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
163347
Make Document::existingAXObjectCache() fast with accessibility disabled.
https://bugs.webkit.org/show_bug.cgi?id=163347
Summary
Make Document::existingAXObjectCache() fast with accessibility disabled.
Andreas Kling
Reported
2016-10-12 11:34:08 PDT
We're spending 2.3% of a Dromaeo/dom-modify.html profile in here and that seems avoidable.
Attachments
Patch
(1.84 KB, patch)
2016-10-12 11:34 PDT
,
Andreas Kling
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2016-10-12 11:34:55 PDT
Created
attachment 291374
[details]
Patch
Antti Koivisto
Comment 2
2016-10-12 12:15:40 PDT
Comment on
attachment 291374
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=291374&action=review
> Source/WebCore/dom/Document.cpp:2430 > +static bool hasEverCreatedAnAXObjectCache = false;
I suppose this works fine in practice (ax being an on/off thing) though in principle this sort of global one-way penalty boxes are somewhat nasty.
WebKit Commit Bot
Comment 3
2016-10-12 12:38:32 PDT
Comment on
attachment 291374
[details]
Patch Clearing flags on attachment: 291374 Committed
r207234
: <
http://trac.webkit.org/changeset/207234
>
WebKit Commit Bot
Comment 4
2016-10-12 12:38:37 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug