In file included from Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:30:
/opt/local/var/macports/build/_Users_jeremy_src_macports_trunk_dports_www_webkit2-gtk-devel/webkit2-gtk-devel/work/webkit-91ef51ea3f538ade6f168a1d701dab90bfbee4db/Source/WebCore/platform/network/soup/SoupNetworkSession.h:67:60: error: no template named 'function' in namespace 'std'; did you mean 'Function'?
static void checkTLSErrors(SoupRequest*, SoupMessage*, std::function<void (const ResourceError&)>&&);
Source/WTF/wtf/Forward.h:70:12: note: 'Function' declared here
Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:330:26: error: out-of-line definition of 'checkTLSErrors' does not match any declaration in 'WebCore::SoupNetworkSession'
void SoupNetworkSession::checkTLSErrors(SoupRequest* soupRequest, SoupMessage* message, std::function<void (const ResourceError&)>&& completionHandler)
2 errors generated.
It looks like a missing #include <functional> in r206807, https://bugs.webkit.org/show_bug.cgi?id=162910
Created attachment 291365 [details]
Comment on attachment 291365 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=291365&action=review
> + Fix a build failure with clang due to std::function usage without #include <functional>
> + https://bugs.webkit.org/show_bug.cgi?id=163340
Please, use the bug title here, prepare-changelog should do that for you.
Oh cool. I thought it just created a template in the ChangeLog that I fill out with the title and the URL. I didn't realize I could pass args to it to do the dirty work for me!
I need to head out, but I'll get an update later today.
Created attachment 291370 [details]
Updated ChangeLog to match title of the bug report
Comment on attachment 291370 [details]
Clearing flags on attachment: 291370
Committed r207232: <http://trac.webkit.org/changeset/207232>
All reviewed patches have been landed. Closing bug.