RESOLVED FIXED Bug 163339
Update more events to stop using legacy [ConstructorTemplate=Event] 
https://bugs.webkit.org/show_bug.cgi?id=163339
Summary Update more events to stop using legacy [ConstructorTemplate=Event]
Chris Dumez
Reported 2016-10-12 10:04:45 PDT
Update more events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Attachments
Patch (42.47 KB, patch)
2016-10-12 10:34 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.17 MB, application/zip)
2016-10-12 11:34 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews103 for mac-yosemite (892.69 KB, application/zip)
2016-10-12 11:39 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews117 for mac-yosemite (1.74 MB, application/zip)
2016-10-12 11:44 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.42 MB, application/zip)
2016-10-12 12:04 PDT, Build Bot 		no flags
Details
Patch (45.73 KB, patch)
2016-10-12 12:31 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2016-10-12 10:34:13 PDT
Created attachment 291368 [details] Patch
Build Bot
Comment 2 2016-10-12 11:34:50 PDT
Comment on attachment 291368 [details] Patch Attachment 291368 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2271609 New failing tests: storage/domstorage/events/basic.html storage/domstorage/events/basic-setattribute.html
Build Bot
Comment 3 2016-10-12 11:34:53 PDT
Created attachment 291373 [details] Archive of layout-test-results from ews106 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews106 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Build Bot
Comment 4 2016-10-12 11:39:51 PDT
Comment on attachment 291368 [details] Patch Attachment 291368 [details] did not pass mac-ews (mac): Output: http://webkit-queues.webkit.org/results/2271647 New failing tests: storage/domstorage/events/basic.html storage/domstorage/events/basic-setattribute.html
Build Bot
Comment 5 2016-10-12 11:39:54 PDT
Created attachment 291375 [details] Archive of layout-test-results from ews103 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: ews103 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 6 2016-10-12 11:44:47 PDT
Comment on attachment 291368 [details] Patch Attachment 291368 [details] did not pass mac-debug-ews (mac): Output: http://webkit-queues.webkit.org/results/2271636 New failing tests: storage/domstorage/events/basic.html storage/domstorage/events/basic-setattribute.html
Build Bot
Comment 7 2016-10-12 11:44:51 PDT
Created attachment 291376 [details] Archive of layout-test-results from ews117 for mac-yosemite The attached test failures were seen while running run-webkit-tests on the mac-debug-ews. Bot: ews117 Port: mac-yosemite Platform: Mac OS X 10.10.5
Build Bot
Comment 8 2016-10-12 12:04:51 PDT
Comment on attachment 291368 [details] Patch Attachment 291368 [details] did not pass ios-sim-ews (ios-simulator-wk2): Output: http://webkit-queues.webkit.org/results/2271659 New failing tests: storage/domstorage/events/basic.html storage/domstorage/events/basic-setattribute.html
Build Bot
Comment 9 2016-10-12 12:04:55 PDT
Created attachment 291377 [details] Archive of layout-test-results from ews122 for ios-simulator-wk2 The attached test failures were seen while running run-webkit-tests on the ios-sim-ews. Bot: ews122 Port: ios-simulator-wk2 Platform: Mac OS X 10.11.6
Ryosuke Niwa
Comment 10 2016-10-12 12:12:07 PDT
Looks like the tests are failing?
Chris Dumez
Comment 11 2016-10-12 12:31:26 PDT
Created attachment 291383 [details] Patch
Chris Dumez
Comment 12 2016-10-12 12:35:18 PDT
(In reply to comment #10) > Looks like the tests are failing? Yes, I fixed them.
Ryosuke Niwa
Comment 13 2016-10-12 13:01:11 PDT
Let's wait for EWS? You can land it & watch the bots as well.
WebKit Commit Bot
Comment 14 2016-10-12 13:44:25 PDT
Comment on attachment 291383 [details] Patch Clearing flags on attachment: 291383 Committed r207238: <http://trac.webkit.org/changeset/207238>
WebKit Commit Bot
Comment 15 2016-10-12 13:44:30 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.