Bug 163339 - Update more events to stop using legacy [ConstructorTemplate=Event]
Summary: Update more events to stop using legacy [ConstructorTemplate=Event]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 10:04 PDT by Chris Dumez
Modified: 2016-10-12 13:44 PDT (History)
6 users (show)

See Also:


Attachments
Patch (42.47 KB, patch)
2016-10-12 10:34 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews106 for mac-yosemite-wk2 (1.17 MB, application/zip)
2016-10-12 11:34 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews103 for mac-yosemite (892.69 KB, application/zip)
2016-10-12 11:39 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews117 for mac-yosemite (1.74 MB, application/zip)
2016-10-12 11:44 PDT, Build Bot
no flags Details
Archive of layout-test-results from ews122 for ios-simulator-wk2 (6.42 MB, application/zip)
2016-10-12 12:04 PDT, Build Bot
no flags Details
Patch (45.73 KB, patch)
2016-10-12 12:31 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-12 10:04:45 PDT
Update more events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Comment 1 Chris Dumez 2016-10-12 10:34:13 PDT
Created attachment 291368 [details]
Patch
Comment 2 Build Bot 2016-10-12 11:34:50 PDT
Comment on attachment 291368 [details]
Patch

Attachment 291368 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2271609

New failing tests:
storage/domstorage/events/basic.html
storage/domstorage/events/basic-setattribute.html
Comment 3 Build Bot 2016-10-12 11:34:53 PDT
Created attachment 291373 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5
Comment 4 Build Bot 2016-10-12 11:39:51 PDT
Comment on attachment 291368 [details]
Patch

Attachment 291368 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2271647

New failing tests:
storage/domstorage/events/basic.html
storage/domstorage/events/basic-setattribute.html
Comment 5 Build Bot 2016-10-12 11:39:54 PDT
Created attachment 291375 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-10-12 11:44:47 PDT
Comment on attachment 291368 [details]
Patch

Attachment 291368 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2271636

New failing tests:
storage/domstorage/events/basic.html
storage/domstorage/events/basic-setattribute.html
Comment 7 Build Bot 2016-10-12 11:44:51 PDT
Created attachment 291376 [details]
Archive of layout-test-results from ews117 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews117  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Build Bot 2016-10-12 12:04:51 PDT
Comment on attachment 291368 [details]
Patch

Attachment 291368 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/2271659

New failing tests:
storage/domstorage/events/basic.html
storage/domstorage/events/basic-setattribute.html
Comment 9 Build Bot 2016-10-12 12:04:55 PDT
Created attachment 291377 [details]
Archive of layout-test-results from ews122 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews122  Port: ios-simulator-wk2  Platform: Mac OS X 10.11.6
Comment 10 Ryosuke Niwa 2016-10-12 12:12:07 PDT
Looks like the tests are failing?
Comment 11 Chris Dumez 2016-10-12 12:31:26 PDT
Created attachment 291383 [details]
Patch
Comment 12 Chris Dumez 2016-10-12 12:35:18 PDT
(In reply to comment #10)
> Looks like the tests are failing?

Yes, I fixed them.
Comment 13 Ryosuke Niwa 2016-10-12 13:01:11 PDT
Let's wait for EWS? You can land it & watch the bots as well.
Comment 14 WebKit Commit Bot 2016-10-12 13:44:25 PDT
Comment on attachment 291383 [details]
Patch

Clearing flags on attachment: 291383

Committed r207238: <http://trac.webkit.org/changeset/207238>
Comment 15 WebKit Commit Bot 2016-10-12 13:44:30 PDT
All reviewed patches have been landed.  Closing bug.