Bug 163331 - [Win] Encode function pointers.
Summary: [Win] Encode function pointers.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-12 07:38 PDT by Per Arne Vollan
Modified: 2018-11-25 22:24 PST (History)
3 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2016-10-12 07:43 PDT, Per Arne Vollan 		bfulgham: review+
bfulgham: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2016-10-12 07:38:13 PDT 
For security reasons, we should encode stored function pointers.
Comment 1 Per Arne Vollan 2016-10-12 07:43:54 PDT 
Created attachment 291356 [details]
Patch
Comment 2 Per Arne Vollan 2016-10-12 07:54:45 PDT 
<rdar://problem/9915523>
Comment 3 Alex Christensen 2016-10-12 08:25:54 PDT 
Comment on attachment 291356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review

> Source/WebCore/platform/win/SoftLinking.h:-105
> -    static resultType callingConvention init##functionName parameterDeclarations \

Are these unit functions no longer needed?
Comment 4 Per Arne Vollan 2016-10-12 10:42:56 PDT 
(In reply to comment #3)
> Comment on attachment 291356 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291356&action=review
> 
> > Source/WebCore/platform/win/SoftLinking.h:-105
> > -    static resultType callingConvention init##functionName parameterDeclarations \
> 
> Are these unit functions no longer needed?

No, these should not be needed anymore. The function pointer will be initialized the first time the function is called.

Thanks for reviewing!
Comment 5 Brent Fulgham 2016-10-12 22:36:31 PDT 
Comment on attachment 291356 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291356&action=review

r=me.

>>> Source/WebCore/platform/win/SoftLinking.h:-105
>>> -    static resultType callingConvention init##functionName parameterDeclarations \
>> 
>> Are these unit functions no longer needed?
> 
> No, these should not be needed anymore. The function pointer will be initialized the first time the function is called.
> 
> Thanks for reviewing!

r=me if you remove the unneeded functions!
Comment 6 Per Arne Vollan 2016-10-13 05:00:57 PDT 
Committed r207282: <http://trac.webkit.org/changeset/207282>