Bug 163326 - Binding generated code for private operations should assert for casted-this checks
Summary: Binding generated code for private operations should assert for casted-this c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-12 03:05 PDT by youenn fablet
Modified: 2016-10-14 00:01 PDT (History)
3 users (show)

See Also:

Attachments
Patch (9.24 KB, patch)
2016-10-12 03:21 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-12 03:05:28 PDT 
Private operations can only be called by WebKit code.
Since we control the call sites, the call sites should make sure to call the operations with the object of the right type.
Comment 1 youenn fablet 2016-10-12 03:21:47 PDT 
Created attachment 291348 [details]
Patch
Comment 2 youenn fablet 2016-10-12 08:42:26 PDT 
(In reply to comment #1)
> Created attachment 291348 [details]
> Patch

This patch makes sense from a technical point of view.
But it requires to be careful on call sites.
I am wondering whether it will not be too easy to miss the necessary check on call sites.
Comment 3 WebKit Commit Bot 2016-10-14 00:01:06 PDT 
Comment on attachment 291348 [details]
Patch

Clearing flags on attachment: 291348

Committed r207328: <http://trac.webkit.org/changeset/207328>
Comment 4 WebKit Commit Bot 2016-10-14 00:01:10 PDT 
All reviewed patches have been landed.  Closing bug.