Bug 163319 – Update remaining DOM events to stop using legacy [ConstructorTemplate=Event]

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Update remaining DOM events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.

[Chris Dumez]

Created attachment 291333 [details]
Patch

[Darin Adler]

Comment on attachment 291333 [details]
Patch

Unclear to me how we get test coverage for the cases where the defaults in IDL don’t match the defaults inside the header file. Also not sure why exactly we need defaults in the header file; for example we don’t have them for any of the JSValue cases.

[Chris Dumez]

Comment on attachment 291333 [details]
Patch

Clearing flags on attachment: 291333

Committed r207215: <http://trac.webkit.org/changeset/207215>

[Chris Dumez]

All reviewed patches have been landed.  Closing bug.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 291333 [details]
> Patch
> 
> Unclear to me how we get test coverage for the cases where the defaults in
> IDL don’t match the defaults inside the header file. Also not sure why
> exactly we need defaults in the header file; for example we don’t have them
> for any of the JSValue cases.

The default values in the struct have actually no impact if the struct is used from bindings code because the generated bindings code will overwrite each member with whatever default value is defined in the IDL. The only use for those default values is in case the struct is used from implementation, which is uncommon (but is done in a few places).