Bug 163319 - Update remaining DOM events to stop using legacy [ConstructorTemplate=Event]
Summary: Update remaining DOM events to stop using legacy [ConstructorTemplate=Event]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-11 22:19 PDT by Chris Dumez
Modified: 2016-10-12 09:30 PDT (History)
9 users (show)

See Also:

Attachments
Patch (101.03 KB, patch)
2016-10-11 22:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-11 22:19:13 PDT 
Update remaining DOM events to stop using legacy [ConstructorTemplate=Event] and use regular constructors instead.
Comment 1 Chris Dumez 2016-10-11 22:26:37 PDT 
Created attachment 291333 [details]
Patch
Comment 2 Darin Adler 2016-10-12 09:18:46 PDT 
Comment on attachment 291333 [details]
Patch

Unclear to me how we get test coverage for the cases where the defaults in IDL don’t match the defaults inside the header file. Also not sure why exactly we need defaults in the header file; for example we don’t have them for any of the JSValue cases.
Comment 3 Chris Dumez 2016-10-12 09:25:38 PDT 
Comment on attachment 291333 [details]
Patch

Clearing flags on attachment: 291333

Committed r207215: <http://trac.webkit.org/changeset/207215>
Comment 4 Chris Dumez 2016-10-12 09:25:43 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Chris Dumez 2016-10-12 09:30:45 PDT 
(In reply to comment #2)
> Comment on attachment 291333 [details]
> Patch
> 
> Unclear to me how we get test coverage for the cases where the defaults in
> IDL don’t match the defaults inside the header file. Also not sure why
> exactly we need defaults in the header file; for example we don’t have them
> for any of the JSValue cases.

The default values in the struct have actually no impact if the struct is used from bindings code because the generated bindings code will overwrite each member with whatever default value is defined in the IDL. The only use for those default values is in case the struct is used from implementation, which is uncommon (but is done in a few places).