Bug 163317 - Annotate bots in contributors.json and don't show them on webkit.org/team
Summary: Annotate bots in contributors.json and don't show them on webkit.org/team
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-11 21:57 PDT by Simon Fraser (smfr)
Modified: 2016-10-14 11:29 PDT (History)
7 users (show)

See Also:

Attachments
Patch (5.37 KB, patch)
2016-10-13 22:27 PDT, Simon Fraser (smfr) 		dbates: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-11 21:57:19 PDT 
Annotate bots in contributors.json and don't show them on webkit.org/team
Comment 1 Simon Fraser (smfr) 2016-10-13 22:27:51 PDT 
Created attachment 291568 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-13 22:30:00 PDT 
Attachment 291568 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 5 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2016-10-14 10:41:19 PDT 
Comment on attachment 291568 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291568&action=review

> Tools/ChangeLog:16
> +        (Reviewer.__init__): Deleted.

This was not deleted. This is a bug in prepare-ChangeLog assuming you used prepare-ChangeLog to generate this change log. Please file a bug for this and attach this patch.
Comment 4 Simon Fraser (smfr) 2016-10-14 11:29:59 PDT 
https://trac.webkit.org/r207350