Bug 163275 - Attribute setter binding generated code should use more references
Summary: Attribute setter binding generated code should use more references
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-11 05:32 PDT by youenn fablet
Modified: 2016-10-12 00:39 PDT (History)
7 users (show)

See Also:

Attachments
Patch (149.25 KB, patch)
2016-10-11 05:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (155.46 KB, patch)
2016-10-12 00:05 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-11 05:32:55 PDT 
Attribute setter binding generated code should use more references
Comment 1 youenn fablet 2016-10-11 05:38:25 PDT 
Created attachment 291249 [details]
Patch
Comment 2 Alex Christensen 2016-10-11 08:10:57 PDT 
Comment on attachment 291249 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291249&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4935
> +    # FIXME: Remove these 3 variables while all JSValueToNative use references.

when
Comment 3 youenn fablet 2016-10-12 00:05:13 PDT 
Created attachment 291342 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-10-12 00:39:53 PDT 
Comment on attachment 291342 [details]
Patch for landing

Clearing flags on attachment: 291342

Committed r207193: <http://trac.webkit.org/changeset/207193>
Comment 5 WebKit Commit Bot 2016-10-12 00:39:57 PDT 
All reviewed patches have been landed.  Closing bug.