Bug 163266 – Update IDBVersionChangeEvent to stop using legacy [ConstructorTemplate=Event]

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Update IDBVersionChangeEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor instead, as in the specification:
- http://w3c.github.io/IndexedDB/#request-idbversionchangeevent

[Chris Dumez]

Created attachment 291230 [details]
Patch

[Build Bot]

Comment on attachment 291230 [details]
Patch

Attachment 291230 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/2260325

New failing tests:
storage/indexeddb/modern/idbversionchangeevent-constructor.html

[Build Bot]

Created attachment 291234 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291230 [details]
Patch

Attachment 291230 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/2260415

New failing tests:
storage/indexeddb/modern/idbversionchangeevent-constructor.html

[Build Bot]

Created attachment 291235 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 291230 [details]
Patch

Attachment 291230 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/2260414

New failing tests:
storage/indexeddb/modern/idbversionchangeevent-constructor.html

[Build Bot]

Created attachment 291236 [details]
Archive of layout-test-results from ews113 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews113  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Chris Dumez]

Created attachment 291237 [details]
Patch

[Darin Adler]

Comment on attachment 291237 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291237&action=review

> Source/WebCore/Modules/indexeddb/IDBVersionChangeEvent.idl:37
> +    unsigned long long  oldVersion = 0;

I don’t think we should have the two spaces here.

[Chris Dumez]

Created attachment 291239 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 291239 [details]
Patch

Clearing flags on attachment: 291239

Committed r207058: <http://trac.webkit.org/changeset/207058>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.