Bug 163243 - Update GamepadEvent to stop using legacy [ConstructorTemplate=Event]
Summary: Update GamepadEvent to stop using legacy [ConstructorTemplate=Event]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Bindings (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-10-10 14:41 PDT by Chris Dumez
Modified: 2016-10-10 19:58 PDT (History)
8 users (show)

See Also:

Attachments
Patch (4.15 KB, patch)
2016-10-10 15:26 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-10 14:41:43 PDT 
Update GamepadEvent to stop using legacy [ConstructorTemplate=Event] and use a proper constructor as in the specification:
- https://w3c.github.io/gamepad/#gamepadevent-interface
Comment 1 Chris Dumez 2016-10-10 15:26:29 PDT 
Created attachment 291174 [details]
Patch
Comment 2 Chris Dumez 2016-10-10 16:58:19 PDT 
FYI, I am aware that the constructor does not match the specification. It is because the specification is wrong: https://github.com/w3c/gamepad/issues/35
Comment 3 WebKit Commit Bot 2016-10-10 19:58:01 PDT 
Comment on attachment 291174 [details]
Patch

Clearing flags on attachment: 291174

Committed r207038: <http://trac.webkit.org/changeset/207038>
Comment 4 WebKit Commit Bot 2016-10-10 19:58:05 PDT 
All reviewed patches have been landed.  Closing bug.