WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
163236
Address some review feedback from
r206979
and
r207010
https://bugs.webkit.org/show_bug.cgi?id=163236
Summary
Address some review feedback from r206979 and r207010
Wenson Hsieh
Reported
2016-10-10 13:00:03 PDT
In TypingCommand.h, some methods on TypingCommand should be marked as final to reflect the fact that they override methods in CompositeEditCommand. Also, HTMLFormControlElement::dispatchFormControlInputEvent does not need to specify HTMLElement::dispatchInputEvent() when calling dispatchInputEvent().
Attachments
Patch
(3.57 KB, patch)
2016-10-10 13:07 PDT
,
Wenson Hsieh
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Wenson Hsieh
Comment 1
2016-10-10 13:07:36 PDT
Created
attachment 291150
[details]
Patch
Tim Horton
Comment 2
2016-10-10 13:19:18 PDT
Comment on
attachment 291150
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=291150&action=review
> Source/WebCore/html/HTMLFormControlElement.cpp:329 > - HTMLElement::dispatchInputEvent(); > + dispatchInputEvent();
This is a fairly surprising thing to have done unintentionally. Are you sure there isn't a closer implementation that it is trying to skip?
Wenson Hsieh
Comment 3
2016-10-10 13:22:54 PDT
(In reply to
comment #2
)
> Comment on
attachment 291150
[details]
> Patch > > View in context: >
https://bugs.webkit.org/attachment.cgi?id=291150&action=review
> > > Source/WebCore/html/HTMLFormControlElement.cpp:329 > > - HTMLElement::dispatchInputEvent(); > > + dispatchInputEvent(); > > This is a fairly surprising thing to have done unintentionally. Are you sure > there isn't a closer implementation that it is trying to skip?
dispatchInputEvent (as a method) is only defined on HTMLElement.
WebKit Commit Bot
Comment 4
2016-10-10 13:55:29 PDT
Comment on
attachment 291150
[details]
Patch Clearing flags on attachment: 291150 Committed
r207018
: <
http://trac.webkit.org/changeset/207018
>
WebKit Commit Bot
Comment 5
2016-10-10 13:55:32 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug