Address some review feedback from r206979 and r207010

[Wenson Hsieh]

In TypingCommand.h, some methods on TypingCommand should be marked as final to reflect the fact that they override methods in CompositeEditCommand. Also, HTMLFormControlElement::dispatchFormControlInputEvent does not need to specify HTMLElement::dispatchInputEvent() when calling dispatchInputEvent().

[Wenson Hsieh]

Created attachment 291150 [details]
Patch

[Tim Horton]

Comment on attachment 291150 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291150&action=review

> Source/WebCore/html/HTMLFormControlElement.cpp:329
> -    HTMLElement::dispatchInputEvent();
> +    dispatchInputEvent();

This is a fairly surprising thing to have done unintentionally. Are you sure there isn't a closer implementation that it is trying to skip?

[Wenson Hsieh]

(In reply to comment #2)
> Comment on attachment 291150 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291150&action=review
> 
> > Source/WebCore/html/HTMLFormControlElement.cpp:329
> > -    HTMLElement::dispatchInputEvent();
> > +    dispatchInputEvent();
> 
> This is a fairly surprising thing to have done unintentionally. Are you sure
> there isn't a closer implementation that it is trying to skip?

dispatchInputEvent (as a method) is only defined on HTMLElement.

[WebKit Commit Bot]

Comment on attachment 291150 [details]
Patch

Clearing flags on attachment: 291150

Committed r207018: <http://trac.webkit.org/changeset/207018>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.