Bug 163197 – Web Inspector: Revealed line not highlighted in TextEditor while debugger paused

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Matt Baker]

Created attachment 291067 [details]
[Video] the bug

Summary:
Revealed line not highlighted in TextEditor while debugger paused. The behavior was changed in https://bugs.webkit.org/show_bug.cgi?id=161658, to eliminate spamming highlight changes when the active call frame changes while debugging.

Instead of always preventing the revealed line from being highlighted whenever the debugger is paused, we should only do so if:

1. Paused in the debugger AND the line being revealed is equal to the executing line.
2. Paused in the debugger AND the executing line is falsey (this means the debugger is paused, and the execution location is being revealed but hasn't been set)

Steps to Reproduce:
1. Inspect:
<script>
(function () {
    function bar() {
        debugger;
    }

    function foo() {
        bar();
    }
    foo();
})();
</script>

2. Reload the page
3. When execution pauses, set a breakpoint somewhere other than the execution location
4. Click the breakpoint in the debugger sidebar
  => The line with the breakpoint isn't highlighted in the editor

[Radar WebKit Bug Importer]

<rdar://problem/28690828>

[Matt Baker]

Created attachment 291068 [details]
Patch

[Timothy Hatcher]

Comment on attachment 291068 [details]
Patch

Good call!

[WebKit Commit Bot]

Comment on attachment 291068 [details]
Patch

Clearing flags on attachment: 291068

Committed r207006: <http://trac.webkit.org/changeset/207006>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Joseph Pecoraro]

This makes stepping behavior look poor. While stepping the line highlights + fades blue despite it having the active line highlight already. This is likely because of the order of operations.

[Joseph Pecoraro]

(In reply to comment #6)
> This makes stepping behavior look poor.

Addressing in bug 163294.