Bug 163193 – Make validate-committer-lists show inactive reviewers

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Simon Fraser (smfr)]

Make validate-committer-lists show inactive reviewers

[Simon Fraser (smfr)]

Created attachment 291061 [details]
Patch

[WebKit Commit Bot]

Attachment 291061 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Sam Weinig]

Comment on attachment 291061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291061&action=review

> Tools/ChangeLog:12
> +        This list is computed by grepping the output of 'git log --since=1.year" for

Does this mean it won't work if you have svn? Can we make this work with SVN as well?

> Tools/ChangeLog:18
> +        Support for aliases is added to Contributor. Aliases are alternates
> +        or misspellings of the reviewer's name. Some common aliases were added to
> +        contributors.json by manual examination of "Reviewed by" lines.

Can I give myself sweet aliases?

[Simon Fraser (smfr)]

(In reply to comment #3)
> Comment on attachment 291061 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291061&action=review
> 
> > Tools/ChangeLog:12
> > +        This list is computed by grepping the output of 'git log --since=1.year" for
> 
> Does this mean it won't work if you have svn?

Yes. The script already does something like:

    if not Git.in_working_directory("."):
        print """\n\nWARNING: validate-committer-lists requires a git checkout.
The following checks are disabled:
 - List of inactive committers
 - List of inactive reviewers
 - List of historical committers missing from contributors.json
"""
        return 1

> Can we make this work with SVN as well?

Possibly, with extra work, which I don't intend to do.

[Simon Fraser (smfr)]

https://trac.webkit.org/r206980

[Sam Weinig]

> > Can we make this work with SVN as well?
> 
> Possibly, with extra work, which I don't intend to do.

I regret my r+ :(. I am really not a fan of tools that don't work in our default configuration. Please please reconsider.

[Chris Dumez]

Bugzilla no longer autocompletes any email. Could this be because of this change?

[Simon Fraser (smfr)]

It works for me. Maybe clear caches?

[Chris Dumez]

(In reply to comment #8)
> It works for me. Maybe clear caches?

Yes, this did the trick. Thank you.