Bug 163193 - Make validate-committer-lists show inactive reviewers
Summary: Make validate-committer-lists show inactive reviewers
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-09 21:57 PDT by Simon Fraser (smfr)
Modified: 2016-10-10 13:18 PDT (History)
8 users (show)

See Also:

Attachments
Patch (14.91 KB, patch)
2016-10-09 22:01 PDT, Simon Fraser (smfr) 		sam: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-09 21:57:09 PDT 
Make validate-committer-lists show inactive reviewers
Comment 1 Simon Fraser (smfr) 2016-10-09 22:01:21 PDT 
Created attachment 291061 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-09 22:04:05 PDT 
Attachment 291061 [details] did not pass style-queue:


ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2016-10-09 22:15:38 PDT 
Comment on attachment 291061 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291061&action=review

> Tools/ChangeLog:12
> +        This list is computed by grepping the output of 'git log --since=1.year" for

Does this mean it won't work if you have svn? Can we make this work with SVN as well?

> Tools/ChangeLog:18
> +        Support for aliases is added to Contributor. Aliases are alternates
> +        or misspellings of the reviewer's name. Some common aliases were added to
> +        contributors.json by manual examination of "Reviewed by" lines.

Can I give myself sweet aliases?
Comment 4 Simon Fraser (smfr) 2016-10-09 22:23:29 PDT 
(In reply to comment #3)
> Comment on attachment 291061 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=291061&action=review
> 
> > Tools/ChangeLog:12
> > +        This list is computed by grepping the output of 'git log --since=1.year" for
> 
> Does this mean it won't work if you have svn?

Yes. The script already does something like:

    if not Git.in_working_directory("."):
        print """\n\nWARNING: validate-committer-lists requires a git checkout.
The following checks are disabled:
 - List of inactive committers
 - List of inactive reviewers
 - List of historical committers missing from contributors.json
"""
        return 1

> Can we make this work with SVN as well?

Possibly, with extra work, which I don't intend to do.
Comment 5 Simon Fraser (smfr) 2016-10-09 22:24:54 PDT 
https://trac.webkit.org/r206980
Comment 6 Sam Weinig 2016-10-09 22:26:10 PDT 
> > Can we make this work with SVN as well?
> 
> Possibly, with extra work, which I don't intend to do.

I regret my r+ :(. I am really not a fan of tools that don't work in our default configuration. Please please reconsider.
Comment 7 Chris Dumez 2016-10-10 13:15:00 PDT 
Bugzilla no longer autocompletes any email. Could this be because of this change?
Comment 8 Simon Fraser (smfr) 2016-10-10 13:16:54 PDT 
It works for me. Maybe clear caches?
Comment 9 Chris Dumez 2016-10-10 13:18:33 PDT 
(In reply to comment #8)
> It works for me. Maybe clear caches?

Yes, this did the trick. Thank you.