Bug 163187 - Update MessageEvent to stop using legacy [ConstructorTemplate=Event]
Summary: Update MessageEvent to stop using legacy [ConstructorTemplate=Event]
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on: 163189
Blocks:
  Show dependency treegraph
 
Reported: 2016-10-09 15:26 PDT by Chris Dumez
Modified: 2016-10-10 13:24 PDT (History)
11 users (show)

See Also:


Attachments
Patch (28.08 KB, patch)
2016-10-10 10:21 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (28.60 KB, patch)
2016-10-10 12:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (28.47 KB, patch)
2016-10-10 13:13 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-09 15:26:24 PDT
Update MessageEvent to stop using legacy [ConstructorTemplate=Event] and use a regular constructor as in the specification:
- https://html.spec.whatwg.org/multipage/comms.html#the-messageevent-interfaces
Comment 1 Chris Dumez 2016-10-10 10:21:44 PDT
Created attachment 291117 [details]
Patch
Comment 2 Darin Adler 2016-10-10 12:06:10 PDT
Comment on attachment 291117 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291117&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:4759
> +        return "MessagePortArray" if $innerType eq "MessagePort";
> +        return "Vector<" . GetNativeVectorInnerType($innerType) . ">";

This looks peculiar enough that it maybe these rules should be in a separate function.

> Source/WebCore/dom/MessageEvent.h:48
> +    struct Init : public EventInit {

No need for "public" here.
Comment 3 Chris Dumez 2016-10-10 12:41:37 PDT
Created attachment 291143 [details]
Patch
Comment 4 Chris Dumez 2016-10-10 13:13:20 PDT
Created attachment 291151 [details]
Patch
Comment 5 Chris Dumez 2016-10-10 13:24:05 PDT
Comment on attachment 291151 [details]
Patch

Clearing flags on attachment: 291151

Committed r207016: <http://trac.webkit.org/changeset/207016>
Comment 6 Chris Dumez 2016-10-10 13:24:11 PDT
All reviewed patches have been landed.  Closing bug.