Bug 163164 - Add support for ClipboardEvent
Summary: Add support for ClipboardEvent
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://www.w3.org/TR/clipboard-apis/...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-10-07 22:16 PDT by Chris Dumez
Modified: 2016-10-08 17:05 PDT (History)
6 users (show)

See Also:


Attachments
Patch (44.58 KB, patch)
2016-10-08 14:59 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (44.82 KB, patch)
2016-10-08 15:16 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (44.79 KB, patch)
2016-10-08 15:36 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (45.00 KB, patch)
2016-10-08 16:15 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff
Patch (44.98 KB, patch)
2016-10-08 16:41 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-10-07 22:16:57 PDT
Add support for ClipboardEvent:
- https://www.w3.org/TR/clipboard-apis/#clipboard-event-interfaces

Firefox and Chrome both already support this.
Comment 1 Chris Dumez 2016-10-08 14:59:29 PDT
Created attachment 291026 [details]
Patch
Comment 2 Chris Dumez 2016-10-08 15:16:40 PDT
Created attachment 291027 [details]
Patch
Comment 3 Chris Dumez 2016-10-08 15:36:21 PDT
Created attachment 291028 [details]
Patch
Comment 4 Chris Dumez 2016-10-08 16:10:12 PDT
Comment on attachment 291028 [details]
Patch

Looks like I broke something.
Comment 5 Chris Dumez 2016-10-08 16:15:09 PDT
Created attachment 291029 [details]
Patch
Comment 6 Darin Adler 2016-10-08 16:38:03 PDT
Comment on attachment 291029 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=291029&action=review

> Source/WebCore/editing/Editor.cpp:886
> +    Ref<ClipboardEvent> event = ClipboardEvent::create(eventType, { true, true, false, dataTransfer.get() }, Event::IsTrusted::Yes);

Can we use auto here instead?
Comment 7 Chris Dumez 2016-10-08 16:41:40 PDT
Created attachment 291031 [details]
Patch
Comment 8 WebKit Commit Bot 2016-10-08 17:05:47 PDT
Comment on attachment 291031 [details]
Patch

Clearing flags on attachment: 291031

Committed r206963: <http://trac.webkit.org/changeset/206963>
Comment 9 WebKit Commit Bot 2016-10-08 17:05:52 PDT
All reviewed patches have been landed.  Closing bug.