Bug 163154 - [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
Summary: [WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-07 16:01 PDT by Simon Fraser (smfr)
Modified: 2016-10-07 17:23 PDT (History)
5 users (show)

See Also:

Attachments
Patch (4.63 KB, patch)
2016-10-07 16:08 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (4.66 KB, patch)
2016-10-07 16:10 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (5.00 KB, patch)
2016-10-07 17:13 PDT, Simon Fraser (smfr) 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2016-10-07 16:01:51 PDT 
[WK1 Mac] Fix repaints of fixed-background elements in layer-backed WebViews
Comment 1 Simon Fraser (smfr) 2016-10-07 16:08:42 PDT 
Created attachment 290980 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-07 16:09:51 PDT 
Attachment 290980 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-10-07 16:10:38 PDT 
Created attachment 290981 [details]
Patch
Comment 4 WebKit Commit Bot 2016-10-07 16:12:39 PDT 
Attachment 290981 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Tim Horton 2016-10-07 16:14:06 PDT 
Comment on attachment 290980 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290980&action=review

> Source/WebKit/mac/WebView/WebClipView.mm:51
>  @interface NSClipView (WebNSClipViewDetails)

Nothing in the () maybe.

> Source/WebKit/mac/WebView/WebHTMLView.mm:4115
> -    if (_private->inScrollPositionChanged) {
> +    if (_private->inScrollPositionChanged && [(WebClipView *)[self superview] currentScrollIsBlit]) {

Maybe check to be safe?
Comment 6 Simon Fraser (smfr) 2016-10-07 17:13:00 PDT 
Created attachment 290986 [details]
Patch
Comment 7 WebKit Commit Bot 2016-10-07 17:14:30 PDT 
Attachment 290986 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebView/WebHTMLView.mm:4122:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebKit/mac/WebView/WebClipView.h:0:  Use #pragma once header guard.  [build/header_guard] [5]
Total errors found: 2 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Tim Horton 2016-10-07 17:15:23 PDT 
Comment on attachment 290986 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290986&action=review

> Source/WebKit/mac/WebView/WebHTMLView.mm:4122
> -    if (_private->inScrollPositionChanged) {
> +    if (_private->inScrollPositionChanged

Do not love this wrapping.
Comment 9 Simon Fraser (smfr) 2016-10-07 17:23:12 PDT 
https://trac.webkit.org/r206945