Bug 163141 - Move ViewGestureController files to more accurate locations
Summary: Move ViewGestureController files to more accurate locations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-07 14:06 PDT by Tim Horton
Modified: 2016-10-07 14:15 PDT (History)
1 user (show)

See Also:

Attachments
Patch (53.54 KB, patch)
2016-10-07 14:06 PDT, Tim Horton 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-10-07 14:06:23 PDT 
Move ViewGestureController files to more accurate locations
Comment 1 Tim Horton 2016-10-07 14:06:37 PDT 
Created attachment 290966 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-07 14:07:51 PDT 
Attachment 290966 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:26:  Use #pragma once instead of #ifndef for header guard.  [build/header_guard] [5]
ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:47:  _UINavigationInteractiveTransitionBase is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:48:  _UIViewControllerOneToOneTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:49:  _UIViewControllerTransitionContext is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:104:  Extra space before ( in function call  [whitespace/parens] [4]
ERROR: Source/WebKit2/UIProcess/Cocoa/ViewGestureController.h:269:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 6 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-10-07 14:15:02 PDT 
https://trac.webkit.org/changeset/206936