Bug 163094 - AX: AXRoleDescription for details and summary elements
Summary: AX: AXRoleDescription for details and summary elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-10-06 17:28 PDT by Nan Wang
Modified: 2016-10-07 10:47 PDT (History)
4 users (show)

See Also:


Attachments
patch (8.47 KB, patch)
2016-10-06 17:34 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (8.46 KB, patch)
2016-10-06 23:03 PDT, Nan Wang
no flags Details | Formatted Diff | Diff
patch (8.38 KB, patch)
2016-10-06 23:48 PDT, Nan Wang
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nan Wang 2016-10-06 17:28:35 PDT
details and summary elements should have AXRoleDescription that is consistent with other elements that have custom AXSubRole.

Expected:
AXGroup/AXDetails/details group
AXGroup/AXSummary/summary group

<rdar://problem/26638751>
Comment 1 Nan Wang 2016-10-06 17:34:07 PDT
Created attachment 290876 [details]
patch
Comment 2 Nan Wang 2016-10-06 23:03:23 PDT
Created attachment 290900 [details]
patch

fixed Efl build failure.
Comment 3 chris fleizach 2016-10-06 23:20:47 PDT
Comment on attachment 290900 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290900&action=review

> Source/WebCore/English.lproj/Localizable.strings:815
> +"details group" = "details group";

don't think we need to add "group" in this string, since it's AXRole is a group
Comment 4 Nan Wang 2016-10-06 23:48:41 PDT
Created attachment 290904 [details]
patch

updated the string.
Comment 5 WebKit Commit Bot 2016-10-07 10:47:22 PDT
Comment on attachment 290904 [details]
patch

Clearing flags on attachment: 290904

Committed r206921: <http://trac.webkit.org/changeset/206921>
Comment 6 WebKit Commit Bot 2016-10-07 10:47:26 PDT
All reviewed patches have been landed.  Closing bug.