Bug 163089 - URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
Summary: URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 14:42 PDT by Alex Christensen
Modified: 2016-10-06 16:07 PDT (History)
0 users

See Also:

Attachments
Patch (13.78 KB, patch)
2016-10-06 14:45 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (14.58 KB, patch)
2016-10-06 15:39 PDT, Alex Christensen 		thorton: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2016-10-06 14:42:04 PDT 
URLParser: Non-ASCII characters in Non-UTF-8 encoded queries of relative URLs with ws, wss, or nonspecial schemes should be UTF-8 encoded
Comment 1 Alex Christensen 2016-10-06 14:45:03 PDT 
Created attachment 290867 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 15:39:44 PDT 
Created attachment 290870 [details]
Patch
Comment 3 Tim Horton 2016-10-06 15:46:08 PDT 
Comment on attachment 290870 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290870&action=review

> Source/WebCore/platform/URL.cpp:471
>          // For UTF-{7,16,32}, we want to use UTF-8 for the query part as

Maybe schlurp the comment out?

> Tools/TestWebKitAPI/Tests/WebCore/URLParser.cpp:1201
> +    if (testTabs == TestTabs::Yes) {

Why not an early return :)
Comment 4 Alex Christensen 2016-10-06 16:07:59 PDT 
http://trac.webkit.org/changeset/206887