Bug 163082 – [GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Michael Catanzaro]

Expose WebKitDOMHTMLInputElement APIs for form autofill

These are needed to make autofill work properly with Angular forms

[Michael Catanzaro]

Created attachment 290864 [details]
Patch

[Darin Adler]

Comment on attachment 290864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290864&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:1013
> +  WTF::String convertedValue = WTF::String::fromUTF8(value);
> +  WebKit::core(self)->setEditingValue(convertedValue);

I would have done this as a 1-liner:

    WebKit::core(self)->setEditingValue(String::fromUTF8(value));

[Carlos Garcia Campos]

Comment on attachment 290864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290864&action=review

We still have the unstable api in 2.14, so we can add this to the unstable api in the stable branch, but the patch in trunk should have a since 2.16, I'll change that when merging in stable

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:496
> + * Since: 2.14.1

This should be 2.16

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:506
> + * Since: 2.14.1

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:516
> + * Since: 2.14.1

Ditto.

[Michael Catanzaro]

Committed r206906: <http://trac.webkit.org/changeset/206906>