Bug 163082 - [GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill
Summary: [GTK] Expose WebKitDOMHTMLInputElement APIs for form autofill
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: Other
Hardware: PC Linux
: P2 Normal
Assignee: Michael Catanzaro
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 14:03 PDT by Michael Catanzaro
Modified: 2016-10-07 02:31 PDT (History)
2 users (show)

See Also:

Attachments
Patch (4.70 KB, patch)
2016-10-06 14:13 PDT, Michael Catanzaro 		darin: review+
cgarcia: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Catanzaro 2016-10-06 14:03:35 PDT 
Expose WebKitDOMHTMLInputElement APIs for form autofill

These are needed to make autofill work properly with Angular forms
Comment 1 Michael Catanzaro 2016-10-06 14:13:19 PDT 
Created attachment 290864 [details]
Patch
Comment 2 Darin Adler 2016-10-06 19:55:18 PDT 
Comment on attachment 290864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290864&action=review

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.cpp:1013
> +  WTF::String convertedValue = WTF::String::fromUTF8(value);
> +  WebKit::core(self)->setEditingValue(convertedValue);

I would have done this as a 1-liner:

    WebKit::core(self)->setEditingValue(String::fromUTF8(value));
Comment 3 Carlos Garcia Campos 2016-10-07 00:41:40 PDT 
Comment on attachment 290864 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290864&action=review

We still have the unstable api in 2.14, so we can add this to the unstable api in the stable branch, but the patch in trunk should have a since 2.16, I'll change that when merging in stable

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:496
> + * Since: 2.14.1

This should be 2.16

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:506
> + * Since: 2.14.1

Ditto.

> Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMHTMLInputElement.h:516
> + * Since: 2.14.1

Ditto.
Comment 4 Michael Catanzaro 2016-10-07 02:31:04 PDT 
Committed r206906: <http://trac.webkit.org/changeset/206906>