Bug 163044 – Address flaky airplay-* LayouTests

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

Address flaky airplay-* LayouTests

[Jer Noble]

Created attachment 290863 [details]
Patch

[WebKit Commit Bot]

Attachment 290863 [details] did not pass style-queue:


ERROR: Source/WebCore/Modules/mediasession/WebMediaSessionManager.h:49:  std::unique_ptr is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 1 in 17 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Brent Fulgham]

Comment on attachment 290863 [details]
Patch

This looks fine. You need someone to review the WK2 part of this (Beth or Alex Christensen?)

[Alexey Proskuryakov]

Comment on attachment 290863 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290863&action=review

> Source/WebCore/ChangeLog:8
> +        AirPlay LayoutTests will occasionally flake, likely due to two tests being run simultaneously. This is because

When multiple tests are run simultaneously, that's in separate DumpRenderTree/WebKitTestRunner processes. So, this doesn't sound like a feasible explanation.

Perhaps there is a race when navigating from one test to another?

[Jer Noble]

(In reply to comment #4)
> Comment on attachment 290863 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=290863&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        AirPlay LayoutTests will occasionally flake, likely due to two tests being run simultaneously. This is because
> 
> When multiple tests are run simultaneously, that's in separate
> DumpRenderTree/WebKitTestRunner processes. So, this doesn't sound like a
> feasible explanation.
> 
> Perhaps there is a race when navigating from one test to another?

Yes, I came to that conclusion myself.  I think there is a simpler explanation: the mock AirPlay picker isn't being reset to consistent values between tests. So depending on the order in which tests are run, tests could have inconsistent results, time out, etc.

[Jer Noble]

Created attachment 290939 [details]
Patch

[Brent Fulgham]

Comment on attachment 290939 [details]
Patch

Wow! So much simpler than before :-) r=me.

[WebKit Commit Bot]

Comment on attachment 290939 [details]
Patch

Clearing flags on attachment: 290939

Committed r207005: <http://trac.webkit.org/changeset/207005>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.