Bug 163014 - CachedResource client handling methods should take reference
Summary: CachedResource client handling methods should take reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 08:05 PDT by youenn fablet
Modified: 2016-10-06 09:56 PDT (History)
1 user (show)

See Also:

Attachments
Patch (66.03 KB, patch)
2016-10-06 08:07 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-06 08:05:21 PDT 
CachedResource client handling methods should take reference
Comment 1 youenn fablet 2016-10-06 08:07:39 PDT 
Created attachment 290823 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 09:12:39 PDT 
Comment on attachment 290823 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290823&action=review

> Source/WebCore/rendering/style/StyleCachedImage.cpp:188
> +    ASSERT(renderer);

We should go and make this a reference, too
Comment 3 WebKit Commit Bot 2016-10-06 09:56:29 PDT 
Comment on attachment 290823 [details]
Patch

Clearing flags on attachment: 290823

Committed r206867: <http://trac.webkit.org/changeset/206867>
Comment 4 WebKit Commit Bot 2016-10-06 09:56:32 PDT 
All reviewed patches have been landed.  Closing bug.