Bug 163004 - CachedResourceRequest should not need to store defer and preload options
Summary: CachedResourceRequest should not need to store defer and preload options
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 03:12 PDT by youenn fablet
Modified: 2016-10-06 23:02 PDT (History)
4 users (show)

See Also:

Attachments
Patch (17.05 KB, patch)
2016-10-06 03:16 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-06 03:12:38 PDT 
This should be handled by CachedResourceLoader internally.
Comment 1 youenn fablet 2016-10-06 03:16:58 PDT 
Created attachment 290806 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 08:59:26 PDT 
Comment on attachment 290806 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290806&action=review

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:192
> +    auto defer = clientDefersImage(request.resourceRequest().url()) ? DeferOption::DeferredByClient : DeferOption::NoDefer;

I think this auto should be bool.
Comment 3 youenn fablet 2016-10-06 22:39:59 PDT 
Thanks for the review.

> > Source/WebCore/loader/cache/CachedResourceLoader.cpp:192
> > +    auto defer = clientDefersImage(request.resourceRequest().url()) ? DeferOption::DeferredByClient : DeferOption::NoDefer;
> 
> I think this auto should be bool.

defer is of type enum class DeferOption.
Comment 4 WebKit Commit Bot 2016-10-06 23:02:41 PDT 
Comment on attachment 290806 [details]
Patch

Clearing flags on attachment: 290806

Committed r206900: <http://trac.webkit.org/changeset/206900>
Comment 5 WebKit Commit Bot 2016-10-06 23:02:45 PDT 
All reviewed patches have been landed.  Closing bug.