Bug 163003 - [Readable Streams API] Implement generic reader functions
Summary: [Readable Streams API] Implement generic reader functions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Romain Bellessort
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 03:09 PDT by Romain Bellessort
Modified: 2016-10-07 08:13 PDT (History)
3 users (show)

See Also:

Attachments
Patch (5.90 KB, patch)
2016-10-06 03:29 PDT, Romain Bellessort 		no flags Details | Formatted Diff | Diff
Patch (5.91 KB, patch)
2016-10-07 01:21 PDT, Romain Bellessort 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Romain Bellessort 2016-10-06 03:09:06 PDT 
To prepare implementation of BYOBReader, reader generic functions should be implemented (readableStreamReaderGenericCancel/Initialize/Release).
Comment 1 Romain Bellessort 2016-10-06 03:29:29 PDT 
Created attachment 290808 [details]
Patch
Comment 2 WebKit Commit Bot 2016-10-06 12:39:13 PDT 
Comment on attachment 290808 [details]
Patch

Rejecting attachment 290808 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 290808, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ded at 1 with fuzz 3.
patching file Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js
Hunk #2 FAILED at 57.
1 out of 2 hunks FAILED -- saving rejects to file Source/WebCore/Modules/streams/ReadableStreamDefaultReader.js.rej
patching file Source/WebCore/Modules/streams/ReadableStreamInternals.js
Hunk #1 succeeded at 36 with fuzz 2.

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Darin Adler']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.webkit.org/results/2233005
Comment 3 Romain Bellessort 2016-10-07 01:21:51 PDT 
Created attachment 290913 [details]
Patch
Comment 4 Romain Bellessort 2016-10-07 01:23:43 PDT 
Commit queue failed due to a previous commit (usage of @throwTypeError). Appropriate merge was done in the new version of the patch.
Comment 5 WebKit Commit Bot 2016-10-07 08:13:17 PDT 
Comment on attachment 290913 [details]
Patch

Clearing flags on attachment: 290913

Committed r206912: <http://trac.webkit.org/changeset/206912>
Comment 6 WebKit Commit Bot 2016-10-07 08:13:20 PDT 
All reviewed patches have been landed.  Closing bug.