Bug 163002 - Add a place for common HTTP Header values
Summary: Add a place for common HTTP Header values
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-06 01:35 PDT by youenn fablet
Modified: 2016-10-10 11:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (12.59 KB, patch)
2016-10-06 01:38 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Patch for landing (12.62 KB, patch)
2016-10-06 22:29 PDT, youenn fablet 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2016-10-06 01:35:54 PDT 
Some HTTP header values like content type are often used in various places.
Comment 1 youenn fablet 2016-10-06 01:38:24 PDT 
Created attachment 290796 [details]
Patch
Comment 2 Alex Christensen 2016-10-06 08:43:51 PDT 
Comment on attachment 290796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290796&action=review

> Source/WebCore/ChangeLog:3
> +        Add a place for usual HTTP Header values

usual -> common?
Comment 3 youenn fablet 2016-10-06 22:29:33 PDT 
Created attachment 290896 [details]
Patch for landing
Comment 4 youenn fablet 2016-10-06 22:29:52 PDT 
Thanks for the review.

> > Source/WebCore/ChangeLog:3
> > +        Add a place for usual HTTP Header values
> 
> usual -> common?

Done
Comment 5 WebKit Commit Bot 2016-10-06 23:03:55 PDT 
Comment on attachment 290896 [details]
Patch for landing

Clearing flags on attachment: 290896

Committed r206901: <http://trac.webkit.org/changeset/206901>
Comment 6 WebKit Commit Bot 2016-10-06 23:03:59 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 7 Darin Adler 2016-10-07 09:23:09 PDT 
Comment on attachment 290896 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=290896&action=review

> Source/WebCore/platform/network/HTTPHeaderValues.h:31
> +struct HTTPHeaderValues {

What is the benefit to using a struct instead of a namespace here?

> Source/WebCore/platform/network/HTTPHeaderValues.h:33
> +    static const String& TextPlainContentType();
> +    static const String& FormURLEncodedContentType();

This doesn’t match WebKit coding style. Function names should start with a lower case letter.
Comment 8 Alex Christensen 2016-10-10 11:11:55 PDT 
https://bugs.webkit.org/show_bug.cgi?id=163203