Bug 163002 – Add a place for common HTTP Header values

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[youenn fablet]

Some HTTP header values like content type are often used in various places.

[youenn fablet]

Created attachment 290796 [details]
Patch

[Alex Christensen]

Comment on attachment 290796 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290796&action=review

> Source/WebCore/ChangeLog:3
> +        Add a place for usual HTTP Header values

usual -> common?

[youenn fablet]

Created attachment 290896 [details]
Patch for landing

[youenn fablet]

Thanks for the review.

> > Source/WebCore/ChangeLog:3
> > +        Add a place for usual HTTP Header values
> 
> usual -> common?

Done

[WebKit Commit Bot]

Comment on attachment 290896 [details]
Patch for landing

Clearing flags on attachment: 290896

Committed r206901: <http://trac.webkit.org/changeset/206901>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 290896 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=290896&action=review

> Source/WebCore/platform/network/HTTPHeaderValues.h:31
> +struct HTTPHeaderValues {

What is the benefit to using a struct instead of a namespace here?

> Source/WebCore/platform/network/HTTPHeaderValues.h:33
> +    static const String& TextPlainContentType();
> +    static const String& FormURLEncodedContentType();

This doesn’t match WebKit coding style. Function names should start with a lower case letter.

[Alex Christensen]

https://bugs.webkit.org/show_bug.cgi?id=163203