When using webkit1 web view, it's unable to edit user editable fields in iframe when using VO navigation to access them.
<rdar://problem/28647519>
Created attachment 290787 [details] patch
Comment on attachment 290787 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290787&action=review > Source/WebCore/ChangeLog:8 > + In webkit1, the top web area setting the selection to an input element inside an iframe WebKit1 > Source/WebCore/ChangeLog:11 > + the input's frame and cause unwanted behavior. Fixed it by not setting the selection in such case. What was the unwanted behavior? Fixed it -> I fixed it > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2043 > + // In webkit1, when the top web area sets the selection to be an input element in an iframe, the caret will disappear. In WebKit1
Created attachment 290789 [details] patch update from review
Comment on attachment 290789 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=290789&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:2045 > + if (isWebArea() && parentObject() && parentObject()->isAttachment()) { we should probably put this in a helper method. isRangeInDifferentDocument(range) or something to that effect thanks
Committed r206854: <http://trac.webkit.org/changeset/206854>
The LayoutTest added with this change was asserting on mac-wk2 debug testers. Based on the changelog (and test name), I going to assume this isn't expected to work on wk2. Skipped test on mac-wk2 in http://trac.webkit.org/projects/webkit/changeset/206865