Bug 162983 - Make it possible to test ViewSnapshotStore behaviors
Summary: Make it possible to test ViewSnapshotStore behaviors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-10-05 13:21 PDT by Tim Horton
Modified: 2016-10-05 15:35 PDT (History)
5 users (show)

See Also:

Attachments
Patch (27.04 KB, patch)
2016-10-05 13:23 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-10-05 13:21:52 PDT 
Make it possible to test ViewSnapshotStore behaviors
Comment 1 Tim Horton 2016-10-05 13:23:27 PDT 
Created attachment 290745 [details]
Patch
Comment 2 Simon Fraser (smfr) 2016-10-05 13:53:14 PDT 
Comment on attachment 290745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290745&action=review

> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233
> +CGImageRef ViewSnapshot::asImageForTesting()

I would prefer this as a "create" or "copy" function.
Comment 3 Tim Horton 2016-10-05 14:17:09 PDT 
https://trac.webkit.org/changeset/206829
Comment 4 Anders Carlsson 2016-10-05 15:35:19 PDT 
Comment on attachment 290745 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=290745&action=review

>> Source/WebKit2/UIProcess/mac/ViewSnapshotStore.mm:233
>> +CGImageRef ViewSnapshot::asImageForTesting()
> 
> I would prefer this as a "create" or "copy" function.

I would have preferred if this just returned a RetainPtr.