ENABLE_LEGACY_ENCRYPTED_MEDIA interfaces should have a hard-coded WebKit prefix
To avoid conflicting interfaces between LEGACY_ENCRYPTED_MEDIA and future ENCRYPTED_MEDIA implementations, we agreed to prefix the LEGACY_ENCRYPTED_MEDIA implementations. The patch would also move these interfaces under Modules/encryptedmedia/legacy/. Remaining items needed for a reviewable patch: - is it fine to prefix the Web-exposed MediaKeyNeededEvent interface, which is currently not prefixed? - Xcode build system updates.
Created attachment 290744 [details] Patch
Attachment 290744 [details] did not pass style-queue: ERROR: Source/WebCore/html/WebKitMediaKeyError.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:142: There should be exactly one empty line instead of 0 between "Modules/battery" and "Modules/encryptedmedia/legacy". [list/emptyline] [5] Total errors found: 9 in 28 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 290805 [details] Patch
Attachment 290805 [details] did not pass style-queue: ERROR: Source/WebCore/html/WebKitMediaKeyError.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:142: There should be exactly one empty line instead of 0 between "Modules/battery" and "Modules/encryptedmedia/legacy". [list/emptyline] [5] Total errors found: 9 in 29 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 290805 [details] Patch Attachment 290805 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.webkit.org/results/2230642 New failing tests: js/dom/global-constructors-attributes.html
Created attachment 290809 [details] Archive of layout-test-results from ews104 for mac-yosemite-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: ews104 Port: mac-yosemite-wk2 Platform: Mac OS X 10.10.5
Created attachment 290811 [details] Patch
Attachment 290811 [details] did not pass style-queue: ERROR: Source/WebCore/html/WebKitMediaKeyError.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] ERROR: Source/WebCore/CMakeLists.txt:142: There should be exactly one empty line instead of 0 between "Modules/battery" and "Modules/encryptedmedia/legacy". [list/emptyline] [5] Total errors found: 9 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Zan, this patch will be much easier to review if you generate the patch by hand with rename detection turned on. (i.e., `git format-patch -M -1`).
(In reply to comment #10) > Zan, this patch will be much easier to review if you generate the patch by > hand with rename detection turned on. (i.e., `git format-patch -M -1`). Thanks for the tip, will use it.
Created attachment 290910 [details] Patch
Attachment 290910 [details] did not pass style-queue: ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeySession.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyNeededEvent.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeys.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/Modules/encryptedmedia/legacy/WebKitMediaKeyMessageEvent.h:27: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:26: Use #pragma once instead of #ifndef for header guard. [build/header_guard] [5] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:39: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:40: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:41: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:42: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:43: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:44: enum members should use InterCaps with an initial capital letter or initial 'k' for C-style enums. [readability/enum_casing] [4] ERROR: Source/WebCore/html/WebKitMediaKeyError.h:54: Should be indented on a separate line, with the colon or comma first on that line. [whitespace/indent] [4] ERROR: Source/WebCore/CMakeLists.txt:142: There should be exactly one empty line instead of 0 between "Modules/battery" and "Modules/encryptedmedia/legacy". [list/emptyline] [5] Total errors found: 13 in 34 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 290910 [details] Patch Clearing flags on attachment: 290910 Committed r206983: <http://trac.webkit.org/changeset/206983>
All reviewed patches have been landed. Closing bug.